linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/6] arm64: ftrace: adjust callsite addresses examined by stack tracer
Date: Mon, 2 Nov 2015 18:43:31 +0000	[thread overview]
Message-ID: <20151102184330.GK2684@leverpostej> (raw)
In-Reply-To: <20151102184124.GO29657@arm.com>

On Mon, Nov 02, 2015 at 06:41:24PM +0000, Will Deacon wrote:
> On Mon, Nov 02, 2015 at 06:29:28PM +0000, Mark Rutland wrote:
> > On Mon, Nov 02, 2015 at 01:20:43PM -0500, Steven Rostedt wrote:
> > > On Fri, 30 Oct 2015 11:16:19 +0000
> > > Will Deacon <will.deacon@arm.com> wrote:
> > > 
> > > > On Fri, Oct 30, 2015 at 02:25:36PM +0900, AKASHI Takahiro wrote:
> > > > > On arm64, no PC values returned by save_stack_trace() will match to LR
> > > > > values saved in stack frames on a stack after the following commit:
> > > > >     commit e306dfd06fcb ("ARM64: unwind: Fix PC calculation")
> > > > > As a result, the output from stack tracer will be messed up.
> > > > 
> > > > FWIW, we've decided to revert that patch for the moment. We're the only
> > > > architecture making that kind of adjustment, so we should fix that before
> > > > building on top of it.
> > > > 
> > > >
> > > 
> > > What is the status of this patch set. I'm currently pulling in last
> > > minute patches for 4.3 and should the ftrace patch in this series be
> > > applied? (I still need to review it too).
> > 
> > The revert Will mentioned is in v4.3 (see commit 9702970c7bd3e2d6), so
> > this series needs a respin to account for that.
> 
> Right, but we're talking about the core ftrace change in patch 4, which
> is (afaict) independent of the commit you mention above.

Ah; I don't know on that front, sorry for the noise.

Mark.

  reply	other threads:[~2015-11-02 18:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30  5:25 [PATCH v4 0/6] arm64: ftrace: fix incorrect output from stack tracer AKASHI Takahiro
2015-10-30  5:25 ` [PATCH v4 1/6] arm64: ftrace: adjust callsite addresses examined by " AKASHI Takahiro
2015-10-30 11:16   ` Will Deacon
2015-11-02 18:20     ` Steven Rostedt
2015-11-02 18:29       ` Mark Rutland
2015-11-02 18:41         ` Will Deacon
2015-11-02 18:43           ` Mark Rutland [this message]
2015-10-30  5:25 ` [PATCH v4 2/6] arm64: ftrace: modify a stack frame in a safe way AKASHI Takahiro
2015-10-30  5:25 ` [PATCH v4 3/6] arm64: ftrace: fix a stack tracer's output under function graph tracer AKASHI Takahiro
2015-11-01  8:00   ` Jungseok Lee
2015-11-04  7:49     ` AKASHI Takahiro
2015-10-30  5:25 ` [PATCH v4 4/6] ftrace: allow arch-specific stack tracer AKASHI Takahiro
2015-10-30  5:25 ` [PATCH v4 5/6] arm64: insn: add instruction decoders for ldp/stp and add/sub AKASHI Takahiro
2015-10-30  5:25 ` [PATCH v4 6/6] arm64: ftrace: add arch-specific stack tracer AKASHI Takahiro
2015-11-01  8:30   ` Jungseok Lee
2015-11-04  8:01     ` AKASHI Takahiro
2015-11-04  8:42   ` yalin wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151102184330.GK2684@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).