From: lkp@intel.com (kbuild test robot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] tty: xuartps: Use spinlock to serialize HW access
Date: Wed, 4 Nov 2015 08:52:54 +0800 [thread overview]
Message-ID: <201511040850.KOF8sWEr%fengguang.wu@intel.com> (raw)
In-Reply-To: <1446596450-20918-3-git-send-email-soren.brinkmann@xilinx.com>
Hi Soren,
[auto build test WARNING on v4.3-rc7]
[also WARNING on: next-20151103]
url: https://github.com/0day-ci/linux/commits/Soren-Brinkmann/tty-xuartps-Beautify-read-modify-writes/20151104-082546
base: https://github.com/0day-ci/linux Soren-Brinkmann/tty-xuartps-Beautify-read-modify-writes/20151104-082546
config: i386-allmodconfig (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/tty/serial/xilinx_uartps.c: In function 'cdns_uart_poll_get_char':
>> drivers/tty/serial/xilinx_uartps.c:948:6: warning: unused variable 'imr' [-Wunused-variable]
u32 imr;
^
drivers/tty/serial/xilinx_uartps.c: In function 'cdns_uart_poll_put_char':
drivers/tty/serial/xilinx_uartps.c:968:6: warning: unused variable 'imr' [-Wunused-variable]
u32 imr;
^
vim +/imr +948 drivers/tty/serial/xilinx_uartps.c
19038ad9f Lars-Peter Clausen 2014-11-05 932
19f22efdb Thomas Betker 2015-03-12 933 val = readl(port->membase + CDNS_UART_MODEMCR_OFFSET);
19038ad9f Lars-Peter Clausen 2014-11-05 934
19038ad9f Lars-Peter Clausen 2014-11-05 935 val &= ~(CDNS_UART_MODEMCR_RTS | CDNS_UART_MODEMCR_DTR);
19038ad9f Lars-Peter Clausen 2014-11-05 936
19038ad9f Lars-Peter Clausen 2014-11-05 937 if (mctrl & TIOCM_RTS)
19038ad9f Lars-Peter Clausen 2014-11-05 938 val |= CDNS_UART_MODEMCR_RTS;
19038ad9f Lars-Peter Clausen 2014-11-05 939 if (mctrl & TIOCM_DTR)
19038ad9f Lars-Peter Clausen 2014-11-05 940 val |= CDNS_UART_MODEMCR_DTR;
19038ad9f Lars-Peter Clausen 2014-11-05 941
19f22efdb Thomas Betker 2015-03-12 942 writel(val, port->membase + CDNS_UART_MODEMCR_OFFSET);
61ec90169 John Linn 2011-04-30 943 }
61ec90169 John Linn 2011-04-30 944
6ee04c6c5 Vlad Lungu 2013-10-17 945 #ifdef CONFIG_CONSOLE_POLL
d9bb3fb12 Soren Brinkmann 2014-04-04 946 static int cdns_uart_poll_get_char(struct uart_port *port)
6ee04c6c5 Vlad Lungu 2013-10-17 947 {
6ee04c6c5 Vlad Lungu 2013-10-17 @948 u32 imr;
6ee04c6c5 Vlad Lungu 2013-10-17 949 int c;
c2fd7b9d5 Soren Brinkmann 2015-11-03 950 unsigned long flags;
6ee04c6c5 Vlad Lungu 2013-10-17 951
c2fd7b9d5 Soren Brinkmann 2015-11-03 952 spin_lock_irqsave(&port->lock, flags);
6ee04c6c5 Vlad Lungu 2013-10-17 953
6ee04c6c5 Vlad Lungu 2013-10-17 954 /* Check if FIFO is empty */
19f22efdb Thomas Betker 2015-03-12 955 if (readl(port->membase + CDNS_UART_SR_OFFSET) & CDNS_UART_SR_RXEMPTY)
6ee04c6c5 Vlad Lungu 2013-10-17 956 c = NO_POLL_CHAR;
:::::: The code at line 948 was first introduced by commit
:::::: 6ee04c6c5488b2b7fdfa22c771c127411f86e610 tty: xuartps: Add polled mode support for xuartps
:::::: TO: Vlad Lungu <vlad.lungu@windriver.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/octet-stream
Size: 51591 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151104/4b67ff78/attachment-0001.obj>
next prev parent reply other threads:[~2015-11-04 0:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 0:20 [PATCH 0/9] tty: xuartps: Fix lock ups Soren Brinkmann
2015-11-04 0:20 ` [PATCH 1/9] tty: xuartps: Beautify read-modify writes Soren Brinkmann
2015-11-04 0:20 ` [PATCH 2/9] tty: xuartps: Use spinlock to serialize HW access Soren Brinkmann
2015-11-04 0:52 ` kbuild test robot [this message]
2015-11-04 0:20 ` [PATCH 3/9] tty: xuartps: Always enable transmitter in start_tx Soren Brinkmann
2015-11-04 0:20 ` [PATCH 4/9] tty: xuartps: Clear interrupt status register in shutdown Soren Brinkmann
2015-11-04 0:20 ` [PATCH 5/9] tty: xuartps: Improve startup function Soren Brinkmann
2015-11-04 0:20 ` [PATCH 6/9] tty: xuartps: Keep lock for whole ISR Soren Brinkmann
2015-11-04 0:20 ` [PATCH 7/9] tty: xuartps: Acquire port lock for shutdown Soren Brinkmann
2015-11-04 0:20 ` [PATCH 8/9] tty: xuartps: Move RX path into helper function Soren Brinkmann
2015-11-04 0:20 ` [PATCH 9/9] tty: xuartps: Only handle RX IRQs when RX is enabled Soren Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201511040850.KOF8sWEr%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).