[PATCH 3/5] thermal: exynos: Use IS_ERR() because regulator cannot be NULL

Alim Akhtar
2015-10-08T16:46:10Z

Hello,

On Thu, Oct 8, 2015 at 11:04 AM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> The NULL check in probe's error path is not needed because in that time
> the regulator cannot be NULL (regulator_get() returns valid pointer or
> ERR_PTR).
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

> drivers/thermal/samsung/exynos_tmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index bc71a61f0c4a..eac6aebf82f3 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1396,7 +1396,7 @@ err_clk_sec:
> if (!IS_ERR(data->clk_sec))
> clk_unprepare(data->clk_sec);
> err_sensor:
> - if (!IS_ERR_OR_NULL(data->regulator))
> + if (!IS_ERR(data->regulator))
> regulator_disable(data->regulator);
>
> return ret;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Regards,
Alim