linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/3] ARM: at91/dt: sama5d4: Add pinmux for 8-bit MMC0 bus
Date: Thu, 5 Nov 2015 03:25:32 +0100	[thread overview]
Message-ID: <201511050325.32235.marex@denx.de> (raw)
In-Reply-To: <563ABBCD.8090802@atmel.com>

On Thursday, November 05, 2015 at 03:15:41 AM, Josh Wu wrote:
> Hi, Marek
> 
> On 11/5/2015 6:14 AM, Marek Vasut wrote:
> > Add pinmux for the 4 remaining signals used in 8-bit MMC 0
> > bus configuration.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > Cc: Josh Wu <josh.wu@atmel.com>
> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> > ---
> > 
> >   arch/arm/boot/dts/sama5d4.dtsi | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> > 
> > V2: Repair the incorrect comments for the pinmux, original version
> > 
> >      of the commment contained wrong MCI0_DAx references.
> > 
> > diff --git a/arch/arm/boot/dts/sama5d4.dtsi
> > b/arch/arm/boot/dts/sama5d4.dtsi index 48ca530..d086a7d 100644
> > --- a/arch/arm/boot/dts/sama5d4.dtsi
> > +++ b/arch/arm/boot/dts/sama5d4.dtsi
> > @@ -1651,6 +1651,14 @@
> > 
> >   							 AT91_PIOC 9 
AT91_PERIPH_B AT91_PINCTRL_PULL_UP	/* MCI0_DA3,
> >   							 conflict with NAND_D4 
*/
> >   							 
> >   							>;
> >   					
> >   					};
> > 
> > +					pinctrl_mmc0_dat4_7: mmc0_dat4_7 {
> > +						atmel,pins =
> > +							<AT91_PIOC 10 
AT91_PERIPH_B AT91_PINCTRL_PULL_UP	/* MCI0_DA4,
> > conflict with NAND_D5 */ +							 
AT91_PIOC 11 AT91_PERIPH_B
> > AT91_PINCTRL_PULL_UP	/* MCI0_DA5, conflict with NAND_D6 */ +		
					
> > AT91_PIOC 12 AT91_PERIPH_B AT91_PINCTRL_PULL_UP	/* MCI0_DA6, conflict
> > with NAND_D7 */ +							 
AT91_PIOC 13 AT91_PERIPH_B
> > AT91_PINCTRL_PULL_UP	/* MCI0_DA7, conflict with NAND_D8 */
> 
> PC13 is conflicted with NRD/NANDOE, not D8 (PB18).
> with this comment fix, you can add:
> Reviewed-by: Josh Wu <josh.wu@atmel.com>

Thanks, patch is out, hope I got it right this time.

Best regards,
Marek Vasut

  parent reply	other threads:[~2015-11-05  2:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 22:14 [PATCH 1/3] ARM: at91/dt: sama5d4: Fix mmc0 pinmux comments Marek Vasut
2015-11-04 22:14 ` [PATCH V2 2/3] ARM: at91/dt: sama5d4: Add pinmux for 8-bit MMC0 bus Marek Vasut
2015-11-05  2:15   ` Josh Wu
2015-11-05  2:25     ` [PATCH V3 " Marek Vasut
2015-11-05  3:05       ` Josh Wu
2015-11-05  4:01         ` Marek Vasut
2015-11-05  2:25     ` Marek Vasut [this message]
2015-11-04 22:14 ` [PATCH V2 3/3] ARM: at91/dt: sama5d4: Add support for DENX MA5D4 SoM and EVK Marek Vasut
2015-11-05  2:03 ` [PATCH 1/3] ARM: at91/dt: sama5d4: Fix mmc0 pinmux comments Josh Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201511050325.32235.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).