From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: Linus HEAD build break
Date: Fri, 6 Nov 2015 17:09:31 +0100 [thread overview]
Message-ID: <20151106160930.GB525@earth> (raw)
In-Reply-To: <20151106153412.GA525@earth>
Hi,
On Fri, Nov 06, 2015 at 04:34:12PM +0100, Sebastian Reichel wrote:
> On Fri, Nov 06, 2015 at 06:53:52AM -0800, Tony Lindgren wrote:
> > * Felipe Balbi <balbi@ti.com> [151106 06:41]:
> > > Belisko Marek <marek.belisko@gmail.com> writes:
> > > > On Fri, Nov 6, 2015 at 3:24 PM, Felipe Balbi <balbi@ti.com> wrote:
> > > >> Felipe Balbi <balbi@ti.com> writes:
> > > >>> your commit af19161aaed7 ("ARM: dts: twl4030: Add iio properties for bci
> > > >>> subnode") breaks build on current linus/master (which current sits in
> > > >>
> > > >> this commit cannot be found in next. How come it's in linus/master ?
> > > > I did post fix but Tony seems doesn't merge it:
> > > > https://lkml.org/lkml/2015/10/13/816
> > >
> > > looking at that thread, I have no idea how come the old version was
> > > merged in the first place. Tony was clear that it broke build and yet
> > > this patch has made its way to mainline and it didn't even go through
> > > linux-next, which makes the problem worse.
> > >
> > > Now we have a bisection point where the tree (well, some DTS files)
> > > won't even build. This is quite messy.
> >
> > Yes didn't I drop the patch and pointed out it breaks the build?
> >
> > Guys, please stop doing this. Do not merge driver code that has
> > not been sitting in linux next at least a week. And for the dts
> > changes, please make sure you have proper acks.
> >
> > And now we have yet another merge window where things unexpectedly
> > break during the merge window because of untested driver changes.
> >
> > Please repost the fix and I'll ack it and you guys send a new pull
> > request to fix it ASAP explaining how it happened.
>
> mh for some reason I accidently added it to my next branch. I'm not
> sure why, since I did not intend to queue it at all. Sorry for the
> mess.
>
> I wonder why it has not been in next, though. Checking my next tree,
> it should have been there since end of September.
I missed Stephen's messages about the build failure [0] and he
switched to using a checkout from 20150925, which is directly before
the patch. As a result this patch and all following patches have not
been tested in linux-next :(
I will send a revert to you guys in a few minutes, so that I can get
your ACK for sending it as pull request to Torvalds.
[0] https://lkml.org/lkml/2015/9/28/844
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151106/78b06eb3/attachment.sig>
next prev parent reply other threads:[~2015-11-06 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 14:06 Linus HEAD build break Felipe Balbi
2015-11-06 14:24 ` Felipe Balbi
2015-11-06 14:31 ` Belisko Marek
2015-11-06 14:40 ` Felipe Balbi
2015-11-06 14:53 ` Tony Lindgren
2015-11-06 15:34 ` Sebastian Reichel
2015-11-06 16:09 ` Sebastian Reichel [this message]
2015-11-06 19:03 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151106160930.GB525@earth \
--to=sre@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).