From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 6 Nov 2015 11:03:51 -0800 Subject: Linus HEAD build break In-Reply-To: <20151106160930.GB525@earth> References: <871tc31atk.fsf@saruman.tx.rr.com> <87y4ebyznc.fsf@saruman.tx.rr.com> <87vb9fyyvn.fsf@saruman.tx.rr.com> <20151106145351.GA3218@atomide.com> <20151106153412.GA525@earth> <20151106160930.GB525@earth> Message-ID: <20151106190351.GC3218@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Sebastian Reichel [151106 08:09]: > Hi, > > On Fri, Nov 06, 2015 at 04:34:12PM +0100, Sebastian Reichel wrote: > > On Fri, Nov 06, 2015 at 06:53:52AM -0800, Tony Lindgren wrote: > > > * Felipe Balbi [151106 06:41]: > > > > Belisko Marek writes: > > > > > On Fri, Nov 6, 2015 at 3:24 PM, Felipe Balbi wrote: > > > > >> Felipe Balbi writes: > > > > >>> your commit af19161aaed7 ("ARM: dts: twl4030: Add iio properties for bci > > > > >>> subnode") breaks build on current linus/master (which current sits in > > > > >> > > > > >> this commit cannot be found in next. How come it's in linus/master ? > > > > > I did post fix but Tony seems doesn't merge it: > > > > > https://lkml.org/lkml/2015/10/13/816 > > > > > > > > looking at that thread, I have no idea how come the old version was > > > > merged in the first place. Tony was clear that it broke build and yet > > > > this patch has made its way to mainline and it didn't even go through > > > > linux-next, which makes the problem worse. > > > > > > > > Now we have a bisection point where the tree (well, some DTS files) > > > > won't even build. This is quite messy. > > > > > > Yes didn't I drop the patch and pointed out it breaks the build? > > > > > > Guys, please stop doing this. Do not merge driver code that has > > > not been sitting in linux next at least a week. And for the dts > > > changes, please make sure you have proper acks. > > > > > > And now we have yet another merge window where things unexpectedly > > > break during the merge window because of untested driver changes. > > > > > > Please repost the fix and I'll ack it and you guys send a new pull > > > request to fix it ASAP explaining how it happened. > > > > mh for some reason I accidently added it to my next branch. I'm not > > sure why, since I did not intend to queue it at all. Sorry for the > > mess. > > > > I wonder why it has not been in next, though. Checking my next tree, > > it should have been there since end of September. > > I missed Stephen's messages about the build failure [0] and he > switched to using a checkout from 20150925, which is directly before > the patch. As a result this patch and all following patches have not > been tested in linux-next :( > > I will send a revert to you guys in a few minutes, so that I can get > your ACK for sending it as pull request to Torvalds. Sounds good to me. Thanks Tony > [0] https://lkml.org/lkml/2015/9/28/844