linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: heiko.carstens@de.ibm.com (Heiko Carstens)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config
Date: Tue, 10 Nov 2015 12:01:45 +0100	[thread overview]
Message-ID: <20151110110145.GE6672@osiris> (raw)
In-Reply-To: <20151110100547.GC31947@arm.com>

On Tue, Nov 10, 2015 at 10:05:48AM +0000, Will Deacon wrote:
> Hi Heiko,
> 
> On Tue, Nov 10, 2015 at 08:41:24AM +0100, Heiko Carstens wrote:
> > On Fri, Nov 06, 2015 at 04:21:10PM +0000, Will Deacon wrote:
> > > On Sat, Nov 07, 2015 at 12:11:16AM +0800, yalin wang wrote:
> > > > i just enable it on ARM64,
> > > > and it can work,
> > > > i don?t see some special requirement to enable this config .
> > > 
> > > Right, so why does HAVE_LATENCYTOP_SUPPORT exist?
[...]
> > And looking through the kernel there is at least avr32 which would break
> > at build time if the config option would be removed completely.
> > 
> > So.. renaming it to STACKTRACE_TSK_SUPPORT would be a good idea.
> 
> ftrace has a similar issue and solves it by having architectures define
> a `config STACKTRACE_SUPPORT' symbol. Over in kernel/trace/Kconfig,
> there's a `select STACKTRACE if STACKTRACE_SUPPORT', which means
> that kernel/stacktrace.c gets built and a dummy (weak symbol) version of
> save_stack_trace_tsk appears.

Ah, I wasn't aware of the weak symbol.

> I don't think adding another STACKTRACE-related Kconfig option is
> necessarily the best thing to do. Maybe we should instead have LATENCYTOP
> depend on STACKTRACE_SUPPORT (already the case) and select STACKTRACE?

LATENCYTOP also already selects STACKTRACE. So it looks like
HAVE_LATENCYTOP_SUPPORT could simply be removed.

  reply	other threads:[~2015-11-10 11:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06 15:57 [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config yalin wang
2015-11-06 16:05 ` Will Deacon
2015-11-06 16:11   ` yalin wang
2015-11-06 16:21     ` Will Deacon
2015-11-10  7:41       ` Heiko Carstens
2015-11-10 10:05         ` Will Deacon
2015-11-10 11:01           ` Heiko Carstens [this message]
2015-11-10 11:18             ` Will Deacon
2015-11-10 11:24               ` yalin wang
2015-11-10 11:34               ` Heiko Carstens
2015-12-14 22:02                 ` Shi, Yang
2015-12-15  9:48                   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151110110145.GE6672@osiris \
    --to=heiko.carstens@de.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).