linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it
Date: Tue, 10 Nov 2015 11:54:00 +0000	[thread overview]
Message-ID: <20151110115359.GE31947@arm.com> (raw)
In-Reply-To: <D0F23548-7A9E-4D3A-8FBD-1D8DA6FFAA26@gmail.com>

On Tue, Nov 10, 2015 at 07:43:35PM +0800, yalin wang wrote:
> > On Nov 10, 2015, at 19:35, Catalin Marinas <catalin.marinas@arm.com> wrote:
> > On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote:
> >> i have a question,
> >> why FRAME_POINTER  config must be enabled ?
> >> and i see ARM arch can  disable this config .
> >> if i don?t need stack trace dump and the software release is for 
> >> final product , don?t need debug stack trace log .
> >> is it possible to disable it for performance reason ?
> > 
> > If you don't need any stack trace, perf etc., in theory you can disable
> > the option. However, the aarch64 gcc compiler always generates it (I'm
> > not sure whether the AAPCS mandates it). Anyway, the performance impact
> > is very small since there are more general purpose registers available
> > in AArch64 already.
> > 
> i just make a test with -fomit-frame-pointer,  seems gcc can generate code
> without frame pointer,

Building without frame-pointers *severely* limits our ability (as
open-source developers) to debug problems that we are unable to reproduce
locally. Given the lack of widely available hardware compared to the
number of platforms in development, I'm strongly opposed to offering this
as a supported option for mainline kernels without a compelling performance
argument.

We have a significant number of general-purpose registers available on
arm64, so I would expect the omission of a framepointer to have a
somewhat limited impact on performance.

Will

  reply	other threads:[~2015-11-10 11:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 18:09 [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it Yang Shi
2015-11-10 10:37 ` Catalin Marinas
2015-11-10 11:09   ` yalin wang
2015-11-10 11:35     ` Catalin Marinas
2015-11-10 11:43       ` yalin wang
2015-11-10 11:54         ` Will Deacon [this message]
2015-11-10 16:51   ` Shi, Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151110115359.GE31947@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).