linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c
Date: Tue, 10 Nov 2015 13:19:12 +0100	[thread overview]
Message-ID: <20151110121912.GA17308@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1511101127090.5676@kaball.uk.xensource.com>

On Tue, Nov 10, 2015 at 11:27:33AM +0000, Stefano Stabellini wrote:
> On Mon, 9 Nov 2015, Peter Zijlstra wrote:
> > On Thu, Nov 05, 2015 at 05:30:01PM +0000, Stefano Stabellini wrote:
> > > On Thu, 5 Nov 2015, Peter Zijlstra wrote:
> > > > How can this be missing? Things compile fine now, right?
> > > 
> > > Fair enough.
> > > 
> > > 
> > > > So please better explain why we do this change.
> > > 
> > > asm/paravirt.h is included by one of the other headers included in
> > > kernel/sched/cputime.c on x86, but not on other architecures. On arm and
> > > arm64, where I am about to introduce asm/paravirt.h and stolen time
> > > support, without #include <asm/paravirt.h> in cputime.c I would get:
> > > 
> > > kernel/sched/cputime.c: In function ?steal_account_process_tick?:
> > > kernel/sched/cputime.c:260:24: error: ?paravirt_steal_enabled? undeclared (first use in this function)
> > >   if (static_key_false(&paravirt_steal_enabled)) {
> > > 
> > > A bit of digging on x86 (using gcc -E on cputime.c) tells me that
> > > asm/paravirt.h is coming from the following include chain:
> > > 
> > > #include <kernel/sched/sched.h>
> > > #include <linux/spinlock.h>
> > > #include <linux/preempt.h>
> > > #include <asm/preempt.h>
> > > #include <linux/thread_info.h>
> > > #include <asm/thread_info.h>
> > > #include <asm/processor.h>
> > > #include <asm/msr.h>
> > > #include <asm/paravirt.h>
> > 
> > 
> > Fair enough; a slightly shorter version of that for a changelog will do
> > nicely.
> 
> Sure. Can I add your Acked-by to it?

Yep, no objection if the changelog is updated as per the above.

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

  reply	other threads:[~2015-11-10 12:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 15:33 [PATCH v11 0/5] xen/arm/arm64: CONFIG_PARAVIRT and stolen ticks accounting Stefano Stabellini
2015-11-05 15:34 ` [PATCH v11 1/5] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c Stefano Stabellini
2015-11-05 16:48   ` Mark Rutland
2015-11-06 11:11     ` Stefano Stabellini
2015-11-06 12:00       ` Mark Rutland
2015-11-05 15:34 ` [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c Stefano Stabellini
2015-11-05 16:40   ` Peter Zijlstra
2015-11-05 17:30     ` Stefano Stabellini
2015-11-09 17:36       ` Peter Zijlstra
2015-11-10 11:27         ` Stefano Stabellini
2015-11-10 12:19           ` Peter Zijlstra [this message]
2015-11-05 15:34 ` [PATCH v11 3/5] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops Stefano Stabellini
2015-11-10 14:12   ` Stefano Stabellini
2015-11-20 14:31     ` Stefano Stabellini
2015-11-20 14:36       ` Christopher Covington
2015-11-20 14:40         ` Stefano Stabellini
2015-11-20 16:47           ` Russell King - ARM Linux
2015-11-20 17:16             ` Stefano Stabellini
2015-11-05 15:34 ` [PATCH v11 4/5] arm64: " Stefano Stabellini
2015-11-10 14:11   ` Stefano Stabellini
2015-11-17 17:29     ` Will Deacon
2015-11-17 17:34       ` Marc Zyngier
2015-11-17 17:35         ` Will Deacon
2015-11-20 12:19           ` Stefano Stabellini
2015-11-05 15:34 ` [PATCH v11 5/5] xen/arm: account for stolen ticks Stefano Stabellini
2015-11-05 16:57   ` Mark Rutland
2015-11-06 11:39     ` Stefano Stabellini
2015-11-06 11:41       ` David Vrabel
2015-11-06 11:59         ` Mark Rutland
2015-11-06 13:25           ` Vitaly Kuznetsov
2015-11-06 13:19         ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151110121912.GA17308@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).