From mboxrd@z Thu Jan 1 00:00:00 1970 From: peterz@infradead.org (Peter Zijlstra) Date: Tue, 10 Nov 2015 13:19:12 +0100 Subject: [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c In-Reply-To: References: <1446737696-9749-2-git-send-email-stefano.stabellini@eu.citrix.com> <20151105164032.GG3604@twins.programming.kicks-ass.net> <20151109173619.GW3604@twins.programming.kicks-ass.net> Message-ID: <20151110121912.GA17308@twins.programming.kicks-ass.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 10, 2015 at 11:27:33AM +0000, Stefano Stabellini wrote: > On Mon, 9 Nov 2015, Peter Zijlstra wrote: > > On Thu, Nov 05, 2015 at 05:30:01PM +0000, Stefano Stabellini wrote: > > > On Thu, 5 Nov 2015, Peter Zijlstra wrote: > > > > How can this be missing? Things compile fine now, right? > > > > > > Fair enough. > > > > > > > > > > So please better explain why we do this change. > > > > > > asm/paravirt.h is included by one of the other headers included in > > > kernel/sched/cputime.c on x86, but not on other architecures. On arm and > > > arm64, where I am about to introduce asm/paravirt.h and stolen time > > > support, without #include in cputime.c I would get: > > > > > > kernel/sched/cputime.c: In function ?steal_account_process_tick?: > > > kernel/sched/cputime.c:260:24: error: ?paravirt_steal_enabled? undeclared (first use in this function) > > > if (static_key_false(¶virt_steal_enabled)) { > > > > > > A bit of digging on x86 (using gcc -E on cputime.c) tells me that > > > asm/paravirt.h is coming from the following include chain: > > > > > > #include > > > #include > > > #include > > > #include > > > #include > > > #include > > > #include > > > #include > > > #include > > > > > > Fair enough; a slightly shorter version of that for a changelog will do > > nicely. > > Sure. Can I add your Acked-by to it? Yep, no objection if the changelog is updated as per the above. Acked-by: Peter Zijlstra (Intel)