From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/3] ARM: OMAP2+ McASP(3) support for DRA7xx family
Date: Wed, 11 Nov 2015 13:37:19 -0800 [thread overview]
Message-ID: <20151111213718.GH3218@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1510301603530.7580@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [151030 09:11]:
> Hi P?ter
>
> On Fri, 30 Oct 2015, Peter Ujfalusi wrote:
>
> > Changes since v2:
> > - DTS patch added which is needed because of the clock handling changes
> >
> > Felip Balbi reported that linux-next is broken right now since the DTS part of
> > the earlier series has been applied, but we do not have the mcasp hwmod in the
> > kernel:
> > ...
> > [ 0.181029] platform 48468000.mcasp: Cannot lookup hwmod 'mcasp3'
> > ...
> > [ 6.121072] davinci-mcasp 48468000.mcasp: _od_fail_runtime_resume: FIXME: missing hwmod/omap_dev info
> > [ 6.130790] ------------[ cut here ]------------
> > [ 6.135643] WARNING: CPU: 0 PID: 244 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x220/0x34c()
> > [ 6.145576] 44000000.ocp:L3 Custom Error: MASTER MPU TARGET L4_PER2_P3 (Read): Data Access in User mode during Functional access
> > ...
> >
> > This is the followup series for the hwmod changes needed to get audio working
> > on DRA7xx family based boards.
> > The DTS patches has been applied by Tony from the original series:
> > http://www.spinics.net/lists/linux-omap/msg121473.html
> >
> > I have addressed your comments in the hwmod data and did some research also
> > regarding to the use of ahclkx as fclk in the original submission.
> > It turned out that McASP _needs_ all clocks to be enabled (fclk, iclk and
> > ahclkx/r) to be able to access registers. The original patch where we handled
> > the ahclkx as fclk worked, because the fclk clock got enabled in the HW w/o
> > any SW interaction.
> > All in all, the McASP found in DRA7 needs all clocks to be enabled.
> > To satisfy this I have introduced a new flag to hwmod, which means that the
> > listed optional clocks need to be handled alongside with the fclk clock.
>
> Thanks. I'm happy with your series and appreciate the indepth
> investigation. As you probably saw last week, we've hit the limit for
> v4.4-rc1:
>
> http://marc.info/?l=linux-omap&m=144564929721826&w=2
>
> This is why I haven't done anything with this series at this time.
> Unfortunately I don't have a DRA7xx board, so I can't do any testing.
> But if this series fixes a problem with DRA7xx in linux-next, we should
> definitely merge it.
>
> Tony, if you want to take this now, you can either take it with my ack, or
> I can send a pull request. Or, if you'd prefer to take it for v4.4-rc2,
> I can send a pull request after v4.4-rc1.
OK I'll add your ack to the hwmod patches and apply all theree patches into
omap-for-v4.4/fixes as it fixes the splat on beagle x15 Felipe reported.
Regards,
Tony
next prev parent reply other threads:[~2015-11-11 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 7:54 [PATCH v3 0/3] ARM: OMAP2+ McASP(3) support for DRA7xx family Peter Ujfalusi
2015-10-30 7:54 ` [PATCH v3 1/3] ARM: DTS: dra7: Fix McASP3 node regarding to clocks Peter Ujfalusi
2015-10-30 7:54 ` [PATCH v3 2/3] ARM: OMAP2+: hwmod: Add hwmod flag for HWMOD_OPT_CLKS_NEEDED Peter Ujfalusi
2015-10-30 7:55 ` [PATCH v3 3/3] ARM: OMAP: DRA7: hwmod: Add data for McASP3 Peter Ujfalusi
2015-11-11 22:44 ` Tony Lindgren
2015-10-30 16:11 ` [PATCH v3 0/3] ARM: OMAP2+ McASP(3) support for DRA7xx family Paul Walmsley
2015-11-11 8:01 ` Peter Ujfalusi
2015-11-11 21:37 ` Tony Lindgren [this message]
2015-11-11 19:40 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111213718.GH3218@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).