public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: alex.aring@gmail.com (Alexander Aring)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFCv2 2/2] rpi: add support to enable usb power domain
Date: Fri, 13 Nov 2015 13:22:37 +0100	[thread overview]
Message-ID: <20151113122231.GA2959@omega> (raw)
In-Reply-To: <563B0217.4030307@lategoodbye.de>

On Thu, Nov 05, 2015 at 08:15:35AM +0100, Stefan Wahren wrote:
...
> >+	bool "Raspberry Pi power domain driver"
> >+	depends on ARCH_BCM2835
> >+	depends on RASPBERRYPI_FIRMWARE
> >+	select PM_GENERIC_DOMAINS if PM
> 
> Since PM_GENERIC_DOMAINS_OF depends on PM_GENERIC_DOMAINS this line should
> be redundant.
> 

I can't remove the line:

select PM_GENERIC_DOMAINS if PM

here. It's true that "PM_GENERIC_DOMAINS_OF depends on PM_GENERIC_DOMAINS",
but Kconfig can't handle the dependency here with select. That's why
sometimes people teaches me "select is evil".

I will get:

warning: (RASPBERRYPI_POWER) selects PM_GENERIC_DOMAINS_OF which has
unmet direct dependencies (PM_GENERIC_DOMAINS && OF)

otherwise.

Nevertheless we can't also use "depends on PM_GENERIC_DOMAINS if PM"
because, PM_GENERIC_DOMAINS is a hidden entry (has no Kconfig prompt).

- Alex

  parent reply	other threads:[~2015-11-13 12:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 22:45 [RFCv2 0/2] rpi: add support for rpi power domain driver Alexander Aring
2015-11-03 22:45 ` [RFCv2 1/2] power: domain: add pm_genpd_uninit Alexander Aring
2015-11-05  9:01   ` Ulf Hansson
2015-11-05 14:34     ` Alexander Aring
2015-11-11 18:00       ` Alexander Aring
2015-11-11 20:33         ` Ulf Hansson
2015-11-13 12:56           ` Alexander Aring
2015-11-11 20:29       ` Ulf Hansson
2015-11-03 22:45 ` [RFCv2 2/2] rpi: add support to enable usb power domain Alexander Aring
2015-11-05  7:15   ` Stefan Wahren
2015-11-05 14:14     ` Alexander Aring
2015-11-13 12:22     ` Alexander Aring [this message]
2015-11-05 13:35   ` Rob Herring
2015-11-05 14:12     ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151113122231.GA2959@omega \
    --to=alex.aring@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox