[PATCH 1/1] dmaengine: imx-sdma: remove __init annotation on sdma_event_remap

[PATCH 1/1] dmaengine: imx-sdma: remove __init annotation on sdma_event_remap

[Jason Liu]

The sdma_probe function will call sdma_event_remap, but sdma_event_remap
marked with the __init annotation which make the kbuild complains as the
following log:

WARNING: drivers/dma/built-in.o(.text+0x56fc): Section mismatch in reference
from the function sdma_probe() to the function .init.text:sdma_event_remap()
The function sdma_probe() references
the function __init sdma_event_remap().
This is often because sdma_probe lacks a __init
annotation or the annotation of sdma_event_remap is wrong.

Remove the __init annotation on sdma_event_remap to kill this build warning

Signed-off-by: Jason Liu <r64343@freescale.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
---
 drivers/dma/imx-sdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 7058d58..0f6fd42 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1462,7 +1462,7 @@ err_firmware:
 
 #define EVENT_REMAP_CELLS 3
 
-static int __init sdma_event_remap(struct sdma_engine *sdma)
+static int sdma_event_remap(struct sdma_engine *sdma)
 {
 	struct device_node *np = sdma->dev->of_node;
 	struct device_node *gpr_np = of_parse_phandle(np, "gpr", 0);
-- 
1.8.3.2

[PATCH 1/1] dmaengine: imx-sdma: remove __init annotation on sdma_event_remap

[Arnd Bergmann]

On Wednesday 11 November 2015 17:20:49 Jason Liu wrote:
> The sdma_probe function will call sdma_event_remap, but sdma_event_remap
> marked with the __init annotation which make the kbuild complains as the
> following log:
> 
> WARNING: drivers/dma/built-in.o(.text+0x56fc): Section mismatch in reference
> from the function sdma_probe() to the function .init.text:sdma_event_remap()
> The function sdma_probe() references
> the function __init sdma_event_remap().
> This is often because sdma_probe lacks a __init
> annotation or the annotation of sdma_event_remap is wrong.
> 
> Remove the __init annotation on sdma_event_remap to kill this build warning
> 
> Signed-off-by: Jason Liu <r64343@freescale.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> 

Looks good. I wonder why I have not caught this with the randconfig builds yet.

Acked-by: Arnd Bergmann <arnd@arndb.de>

One hint for the future: in the patch description, write less about the
kbuild warning and more about the actual impact of the bug (calling a
discarded function if the device gets unbound and rebound later, or
if we get deferred probing).

	Arnd

[PATCH 1/1] dmaengine: imx-sdma: remove __init annotation on sdma_event_remap

[Liu Jason]

> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd at arndb.de]
> Sent: Wednesday, November 11, 2015 6:02 PM
> To: linux-arm-kernel at lists.infradead.org
> Cc: Liu Hui-R64343; dmaengine at vger.kernel.org; vinod.koul at intel.com;
> dan.j.williams at intel.com; linux-kernel at vger.kernel.org
> Subject: Re: [PATCH 1/1] dmaengine: imx-sdma: remove __init annotation on
> sdma_event_remap
> 
> On Wednesday 11 November 2015 17:20:49 Jason Liu wrote:
> > The sdma_probe function will call sdma_event_remap, but
> > sdma_event_remap marked with the __init annotation which make the
> > kbuild complains as the following log:
> >
> > WARNING: drivers/dma/built-in.o(.text+0x56fc): Section mismatch in
> > reference from the function sdma_probe() to the function
> > .init.text:sdma_event_remap() The function sdma_probe() references the
> > function __init sdma_event_remap().
> > This is often because sdma_probe lacks a __init annotation or the
> > annotation of sdma_event_remap is wrong.
> >
> > Remove the __init annotation on sdma_event_remap to kill this build
> > warning
> >
> > Signed-off-by: Jason Liu <r64343@freescale.com>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> >
> 
> Looks good. I wonder why I have not caught this with the randconfig
> builds yet.
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> One hint for the future: in the patch description, write less about the
> kbuild warning and more about the actual impact of the bug (calling a
> discarded function if the device gets unbound and rebound later, or if we
> get deferred probing).

Yes, that is true indeed. Thanks Arnd.

> 
> 	Arnd

[PATCH 1/1] dmaengine: imx-sdma: remove __init annotation on sdma_event_remap

[Vinod Koul]

On Wed, Nov 11, 2015 at 05:20:49PM +0800, Jason Liu wrote:
> The sdma_probe function will call sdma_event_remap, but sdma_event_remap
> marked with the __init annotation which make the kbuild complains as the
> following log:
> 
> WARNING: drivers/dma/built-in.o(.text+0x56fc): Section mismatch in reference
> from the function sdma_probe() to the function .init.text:sdma_event_remap()
> The function sdma_probe() references
> the function __init sdma_event_remap().
> This is often because sdma_probe lacks a __init
> annotation or the annotation of sdma_event_remap is wrong.
> 
> Remove the __init annotation on sdma_event_remap to kill this build warning

Applied, thanks

-- 
~Vinod