From: mchehab@osg.samsung.com (Mauro Carvalho Chehab)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [MEDIA] dvb: usb: fix dib3000mc dependencies
Date: Tue, 17 Nov 2015 17:00:12 -0200 [thread overview]
Message-ID: <20151117170012.24fe7f58@recife.lan> (raw)
In-Reply-To: <5525192.eyIcy1NRHy@wuerfel>
Em Tue, 17 Nov 2015 17:24:23 +0100
Arnd Bergmann <arnd@arndb.de> escreveu:
> On Tuesday 17 November 2015 17:17:39 Arnd Bergmann wrote:
> > The dibusb_read_eeprom_byte function is defined in dibusb-common.c,
> > but that file is not compiled for CONFIG_DVB_USB_DIBUSB_MB as it
> > is for the other driver using the common functions, so we can
> > get a link error:
> >
> > drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
> > (.text+0x2c5124): undefined reference to `dibusb_read_eeprom_byte'
> > (.text+0x2c5134): undefined reference to `dibusb_read_eeprom_byte'
> >
> > This changes the Makefile to treat the file like all the others
> > in this directory, and enforce building dvb-usb-dibusb-common.o
> > as a dependency.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
>
> I just realized that this depends on another patch I've sent back
> in April, so that is probably no longer in the patch queue. Please
> disregard for now.
Hi Arnd,
The better way to fix it is to do a patch like this one:
http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?id=8abe4a0a3f6d4217b16a1a3f68cd5c72ab5a058e
The problem with those dib drivers is that there's no way to latter
remove them with rmmod. Using the above techinique, not only ranconfig
compilation will work, but it will also allow module remove and having
drivers with some frontends disabled.
The drawback is that it is not a very trivial patch, so I did the
changes only for devices that I have (all based on dib0700).
Unfortunately, I don't have any device currently based on dib3000.
I could work on such patchset, but someone would need to test it ;)
Regards,
Mauro
prev parent reply other threads:[~2015-11-17 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 16:17 [PATCH] [MEDIA] dvb: usb: fix dib3000mc dependencies Arnd Bergmann
2015-11-17 16:24 ` Arnd Bergmann
2015-11-17 19:00 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117170012.24fe7f58@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).