linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] USB: USB_OTG does not depend on PM
Date: Wed, 18 Nov 2015 17:41:48 +0800	[thread overview]
Message-ID: <20151118094147.GI4228@shlinux2> (raw)
In-Reply-To: <5217888.FiujFV8yJj@wuerfel>

On Wed, Nov 18, 2015 at 10:38:18AM +0100, Arnd Bergmann wrote:
> On Wednesday 18 November 2015 11:17:50 Peter Chen wrote:
> > From 3a6918dae038aadc200dcf0263f4440acc2353d4 Mon Sep 17 00:00:00 2001
> > From: Peter Chen <peter.chen@freescale.com>
> > Date: Wed, 18 Nov 2015 11:06:34 +0800
> > Subject: [PATCH 1/1] usb: kconfig: fix warning of select USB_OTG
> > 
> > When choose randconfig for kernel build, it reports below warning:
> > "warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG
> > which has unmet direct dependencies (USB_SUPPORT && USB && PM)"
> > 
> > In fact, USB_OTG is visual symbol and depends on PM, so the driver
> 
>                       visible ?

Yes, will change this typo

> 
> > needs to depend on it to reduce dependency problem.
> > 
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > Reported-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Felipe Balbi <balbi@ti.com>
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> I was a bit worried that this might break defconfig files that now
> no longer automatically get OSB_OTG enabled, but I have checked all
> defconfig files we have in the kernel and none of them uses
> USB_OTG_FSM, FSL_USB2_OTG or USB_MV_OTG, so we are fine.

Thanks.

> 
> Thanks!
> 
> 	Arnd

-- 

Best Regards,
Peter Chen

      reply	other threads:[~2015-11-18  9:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-17 21:01 [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann
2015-11-17 21:38 ` Felipe Balbi
2015-11-17 22:00   ` Arnd Bergmann
2015-11-17 22:21     ` Felipe Balbi
2015-11-18  3:17     ` Peter Chen
2015-11-18  9:38       ` Arnd Bergmann
2015-11-18  9:41         ` Peter Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151118094147.GI4228@shlinux2 \
    --to=peter.chen@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).