From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [4.4-rc][PATCH] ARM: dts: am4372: disable arm twd and global timer's nodes
Date: Wed, 18 Nov 2015 14:15:38 +0000 [thread overview]
Message-ID: <20151118141537.GC10644@leverpostej> (raw)
In-Reply-To: <1447855315-419-1-git-send-email-grygorii.strashko@ti.com>
On Wed, Nov 18, 2015 at 04:01:55PM +0200, Grygorii Strashko wrote:
> Keep ARM TWD and Global timer's nodes disabled by default - if someone
> would like to use them then those nodes have to be enabled explicitly
> in board file.
>
> The reason for this change is:
> - ARM TWD is not always-on timer on am437x and it will stop in low
> CPUIdle states and, therefore, broadcast timer has to configured
> properly if CPU_IDLE=y.
> - ARM Global timer is not always-on timer on am437x and it can't be
> used as clocksource device if CPU_IDLE=y.
I don't understand. What timer do you use in the absence of a TWD, and
if it is better why is it not used even if TWD is present?
> - ARM Global timer driver doesn't support CPUfreq now.
Surely that should be fixed in the driver (e.g. make it fail to probe if
CPUfreq is present)? It's broken for any other users too...
Mark.
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> arch/arm/boot/dts/am4372.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index d83ff9c..11376e3 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -75,6 +75,7 @@
> interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> clocks = <&dpll_mpu_m2_ck>;
> + status = "disabled";
> };
>
> local_timer: timer at 48240600 {
> @@ -83,6 +84,7 @@
> interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> clocks = <&dpll_mpu_m2_ck>;
> + status = "disabled";
> };
>
> l2-cache-controller at 48242000 {
> --
> 2.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-11-18 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 14:01 [4.4-rc][PATCH] ARM: dts: am4372: disable arm twd and global timer's nodes Grygorii Strashko
2015-11-18 14:15 ` Mark Rutland [this message]
2015-11-18 15:35 ` Grygorii Strashko
2015-12-03 16:33 ` Tony Lindgren
2015-12-03 16:37 ` Tony Lindgren
2015-12-03 18:20 ` Grygorii Strashko
2015-12-03 19:23 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118141537.GC10644@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).