From mboxrd@z Thu Jan 1 00:00:00 1970 From: edubezval@gmail.com (Eduardo Valentin) Date: Wed, 18 Nov 2015 13:56:55 -0800 Subject: Freescale IMX6 active cooling In-Reply-To: References: <564C0453.6020400@kosagi.com> Message-ID: <20151118215654.GA23251@localhost.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Wed, Nov 18, 2015 at 12:00:05PM +0200, Catalin Crenguta wrote: > On Wed, Nov 18, 2015 at 6:53 AM, Sean Cross wrote: > > Perhaps the correct order of patches is: > > > > 1) Add generic thermal zone support > > 2) Remove zone and cdev from imx_thermal > > 3) Add cpufreq-cooling to imx6 > > 4) Add cpufreq-cooling to all other SoCs that support imx_thermal > > 5) Add default generic thermal zone support to imx6qdl.dtsi > In my opinion, I guess a patch series containing this would be good. The recommendation is for you to use of-thermal, yes. In that way you may benefit of describing your thermal hw specific data over DT. And you can benefit of the existing cooling devices that have DT cooling descriptors too, such as gpio-fan, and cpufreq-cooling, yes. To use cpufreq-cooling, you may want to make sure your device works with cpufreq-dt driver. I would appreciate if you could clean up the IMX code to use the DT way of describing thermal. BR, > > Thanks again! > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html