public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver
Date: Wed, 18 Nov 2015 16:59:04 -0600	[thread overview]
Message-ID: <20151118225904.GA5429@rob-hp-laptop> (raw)
In-Reply-To: <1447840410-19794-1-git-send-email-andy.yan@rock-chips.com>

On Wed, Nov 18, 2015 at 05:53:30PM +0800, Andy Yan wrote:
> Add devicetree binding document for rockchip reboot nofifier driver

Just reading the subject this is way too specific to the Linux driver 
needs rather than a h/w description. Please don't create fake DT nodes 
just to bind to drivers. Whatever &pmu is is probably what should have 
the DT node. Let the driver for it create child devices if you need 
that.

Rob
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> 
> ---
> 
> Changes in v3:
>  - add dt binding
> 
> Changes in v2: None
> 
>  .../bindings/soc/rockchip/rockchip-reboot.txt          | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/rockchip/rockchip-reboot.txt
> 
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/rockchip-reboot.txt b/Documentation/devicetree/bindings/soc/rockchip/rockchip-reboot.txt
> new file mode 100644
> index 0000000..6f69c8d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/rockchip/rockchip-reboot.txt
> @@ -0,0 +1,18 @@
> +Rockchip reboot notifier driver
> +
> +This driver get reboot mode arguments from userspace
> +and stores it in special register. Then the bootloader
> +will read it and take different action according the
> +argument stored.
> +
> +Required properties:
> +- compatible: should be "rockchip,reboot"
> +- regmap: this is phandle to the register map node
> +- offset: offset in the register map for the storage register (in bytes)
> +
> +Examples:
> +	reboot {
> +	   compatible = "rockchip,reboot";
> +	   regmap = <&pmu>;
> +	   offset = <0x94>;
> +	};
> -- 
> 1.9.1
> 
> 

  reply	other threads:[~2015-11-18 22:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18  9:47 [PATCH v3 0/5] Add reboot notifier driver for rockchip platform Andy Yan
2015-11-18  9:50 ` [PATCH v3 1/5] ARM: dts: rockchip: rk3288-veyron: rename pinctrl node reboot to reset Andy Yan
2015-11-18 14:18   ` Sergei Shtylyov
2015-11-18  9:53 ` [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver Andy Yan
2015-11-18 22:59   ` Rob Herring [this message]
2015-11-19  1:17     ` Andy Yan
2015-11-19  4:35       ` Heiko Stuebner
2015-11-20  1:16         ` Andy Yan
2015-11-20  1:58           ` Rob Herring
2015-11-19 12:56       ` Thierry Reding
     [not found]         ` <CANbgqASc1fyoV6FJ1g15P27_h0iA_F9h8aP304X8tRovrKrq5A@mail.gmail.com>
2015-11-19 15:30           ` Thierry Reding
2015-11-18  9:56 ` [PATCH v3 3/5] soc: rockchip: add " Andy Yan
2015-11-19  0:39   ` kbuild test robot
2015-12-14 11:39   ` Arnd Bergmann
2015-12-15 16:31     ` Thierry Reding
2015-12-15 16:34       ` Arnd Bergmann
2015-12-15 17:27         ` Heiko Stübner
2015-12-15 17:42         ` Thierry Reding
2015-12-15 20:38           ` Arnd Bergmann
2015-12-28  9:20             ` Thierry Reding
2015-12-28 15:35               ` Arnd Bergmann
2016-01-21 16:20                 ` Thierry Reding
2015-11-18 10:00 ` [PATCH v3 4/5] ARM: dts: rockchip: add reboot node Andy Yan
2015-11-18 10:05 ` [PATCH v3 5/5] ARM64: " Andy Yan
     [not found] ` <CANbgqARHxXorh8Svuw7tHMT60=j35BEqhMnuCOB6u6-d0NPxEQ@mail.gmail.com>
     [not found]   ` <CANbgqARCYP0rfTPSJLNEnCdrb1+mCYYznnRVH6o8Bj5sWt9fDw@mail.gmail.com>
2015-12-01 15:47     ` [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver Heiko Stübner
2015-12-11 21:29 ` [PATCH v3 0/5] Add reboot notifier driver for rockchip platform Heiko Stübner
2015-12-14 10:30   ` Andy Yan
2015-12-17  1:16     ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151118225904.GA5429@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox