From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Sun, 22 Nov 2015 20:45:56 +0100 Subject: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register In-Reply-To: References: <1447948422-4915-1-git-send-email-mweseloh42@gmail.com> <1447948422-4915-2-git-send-email-mweseloh42@gmail.com> <20151120161246.GB21921@rob-hp-laptop> Message-ID: <20151122194556.GO32142@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Fri, Nov 20, 2015 at 05:45:48PM +0100, Marcus Weseloh wrote: > 2015-11-20 17:12 GMT+01:00 Rob Herring : > > On Fri, Nov 20, 2015 at 02:56:34PM +0100, Marcus Weseloh wrote: > >> > (and the wdelay should > >> > arguably be a core-spi thing, not a sunxi thing, but that's a separate > >> > discussion) > >> > >> I've been thinking about that, but it seemed to big a change to > >> attempt with my limited kernel hacking experience. > > > > It is not any bigger. You just need to document it in the core binding. > > It would still be read by the drivers using it. > > Julien, Rob: thanks for your comments! Ok, I will make the following changes: > > - remove "sun4i,spi-wdelay" from the sun4i binding and add the > property to the spi-bus.txt binding instead > - remove the comment about the additional 3 cycles from the documentation > - modfy the spi-sun4i driver to take care of the minimum 3 cycle period > > Does that sound right? > > And maybe I could also use a more descriptive name for the property, > maybe "spi-word-wait-cycles"? I don't think it should be in a clock-rate dependant unit. Using micro or nano-seconds would be more appropriate I guess. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: