linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: VF610 broken by pinctrl: freescale: imx: allow mux_reg offset zero
Date: Mon, 23 Nov 2015 16:08:23 +0100	[thread overview]
Message-ID: <20151123150823.GA16184@lunn.ch> (raw)
In-Reply-To: <20151123132838.GM13744@tiger>

> Can you please try the following change to see if it fixes your problem?
> 
> Shawn
> 
> diff --git a/drivers/pinctrl/freescale/pinctrl-vf610.c b/drivers/pinctrl/freescale/pinctrl-vf610.c
> index 37a037543d29..587d1ff6210e 100644
> --- a/drivers/pinctrl/freescale/pinctrl-vf610.c
> +++ b/drivers/pinctrl/freescale/pinctrl-vf610.c
> @@ -299,7 +299,7 @@ static const struct pinctrl_pin_desc vf610_pinctrl_pads[] = {
>  static struct imx_pinctrl_soc_info vf610_pinctrl_info = {
>         .pins = vf610_pinctrl_pads,
>         .npins = ARRAY_SIZE(vf610_pinctrl_pads),
> -       .flags = SHARE_MUX_CONF_REG,
> +       .flags = SHARE_MUX_CONF_REG | ZERO_OFFSET_VALID,
>  };
>  
>  static const struct of_device_id vf610_pinctrl_of_match[] = {

Hi Shawn

I'm away from the hardware right now, but yes, that should fix it.

    Andrew

  reply	other threads:[~2015-11-23 15:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-15  2:44 VF610 broken by pinctrl: freescale: imx: allow mux_reg offset zero Andrew Lunn
2015-11-16 15:25 ` Alonso Adrian
2015-11-20 13:54   ` Andrew Lunn
2015-11-23 13:28 ` Shawn Guo
2015-11-23 15:08   ` Andrew Lunn [this message]
2015-11-24  5:41     ` Shawn Guo
2015-11-25  2:10   ` Andrew Lunn
2015-11-25  3:08     ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151123150823.GA16184@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).