linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ARM: imx_v6_v7_defconfig: Select HDMI audio support
@ 2015-11-16 15:20 Fabio Estevam
  2015-11-24  6:20 ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2015-11-16 15:20 UTC (permalink / raw)
  To: linux-arm-kernel

Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio
supported by default.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Select the driver as module instead of built-in

 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 4187f69..f5ca938 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -224,6 +224,7 @@ CONFIG_SOC_CAMERA_OV2640=y
 CONFIG_IMX_IPUV3_CORE=y
 CONFIG_DRM=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
 CONFIG_DRM_IMX=y
 CONFIG_DRM_IMX_FB_HELPER=y
 CONFIG_DRM_IMX_PARALLEL_DISPLAY=y
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2] ARM: imx_v6_v7_defconfig: Select HDMI audio support
  2015-11-16 15:20 [PATCH v2] ARM: imx_v6_v7_defconfig: Select HDMI audio support Fabio Estevam
@ 2015-11-24  6:20 ` Shawn Guo
  2015-11-24  9:25   ` Fabio Estevam
  0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2015-11-24  6:20 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Nov 16, 2015 at 01:20:38PM -0200, Fabio Estevam wrote:
> Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio
> supported by default.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Select the driver as module instead of built-in

I've applied a previous version.  Should I replace it with this one?

Shawn 

> 
>  arch/arm/configs/imx_v6_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 4187f69..f5ca938 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -224,6 +224,7 @@ CONFIG_SOC_CAMERA_OV2640=y
>  CONFIG_IMX_IPUV3_CORE=y
>  CONFIG_DRM=y
>  CONFIG_DRM_PANEL_SIMPLE=y
> +CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
>  CONFIG_DRM_IMX=y
>  CONFIG_DRM_IMX_FB_HELPER=y
>  CONFIG_DRM_IMX_PARALLEL_DISPLAY=y
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] ARM: imx_v6_v7_defconfig: Select HDMI audio support
  2015-11-24  6:20 ` Shawn Guo
@ 2015-11-24  9:25   ` Fabio Estevam
  2015-11-24 14:53     ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2015-11-24  9:25 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Nov 24, 2015 at 4:20 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Mon, Nov 16, 2015 at 01:20:38PM -0200, Fabio Estevam wrote:
>> Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio
>> supported by default.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> Changes since v1:
>> - Select the driver as module instead of built-in
>
> I've applied a previous version.  Should I replace it with this one?

Yes, please.

The latest version uses module instead of built-in.

Selecting the driver as module is better as it will not impact current
users. For example: currently on a mx6qsabresd when we do 'aplay
file.wav' it will play through the wm8962 card.

If the HDMI audio driver is selected as built-in, then 'aplay
file.wav' will play through the HDMI audio port, which may confuse the
end user.

If we select the HDMI audio driver as module then we keep the original
behaviour.

Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] ARM: imx_v6_v7_defconfig: Select HDMI audio support
  2015-11-24  9:25   ` Fabio Estevam
@ 2015-11-24 14:53     ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2015-11-24 14:53 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Nov 24, 2015 at 07:25:13AM -0200, Fabio Estevam wrote:
> On Tue, Nov 24, 2015 at 4:20 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Mon, Nov 16, 2015 at 01:20:38PM -0200, Fabio Estevam wrote:
> >> Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio
> >> supported by default.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >> ---
> >> Changes since v1:
> >> - Select the driver as module instead of built-in
> >
> > I've applied a previous version.  Should I replace it with this one?
> 
> Yes, please.

Done.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-11-24 14:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-16 15:20 [PATCH v2] ARM: imx_v6_v7_defconfig: Select HDMI audio support Fabio Estevam
2015-11-24  6:20 ` Shawn Guo
2015-11-24  9:25   ` Fabio Estevam
2015-11-24 14:53     ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).