* [PATCH] arm64: kvm: avoid %p in __kvm_hyp_panic
@ 2015-11-16 13:55 Mark Rutland
2015-11-24 17:18 ` Christoffer Dall
0 siblings, 1 reply; 2+ messages in thread
From: Mark Rutland @ 2015-11-16 13:55 UTC (permalink / raw)
To: linux-arm-kernel
Currently __kvm_hyp_panic uses %p for values which are not pointers,
such as the ESR value. This can confusingly lead to "(null)" being
printed for the value.
Use %x instead, and only use %p for host pointers.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Cc: Christoffer Dall <christoffer.dall@linaro.org>
---
arch/arm64/kvm/hyp.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kvm/hyp.S b/arch/arm64/kvm/hyp.S
index 1599701..11183ce 100644
--- a/arch/arm64/kvm/hyp.S
+++ b/arch/arm64/kvm/hyp.S
@@ -914,7 +914,7 @@ __kvm_hyp_panic:
ENDPROC(__kvm_hyp_panic)
__hyp_panic_str:
- .ascii "HYP panic:\nPS:%08x PC:%p ESR:%p\nFAR:%p HPFAR:%p PAR:%p\nVCPU:%p\n\0"
+ .ascii "HYP panic:\nPS:%08x PC:%016x ESR:%08x\nFAR:%016x HPFAR:%016x PAR:%016x\nVCPU:%p\n\0"
.align 2
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] arm64: kvm: avoid %p in __kvm_hyp_panic
2015-11-16 13:55 [PATCH] arm64: kvm: avoid %p in __kvm_hyp_panic Mark Rutland
@ 2015-11-24 17:18 ` Christoffer Dall
0 siblings, 0 replies; 2+ messages in thread
From: Christoffer Dall @ 2015-11-24 17:18 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 16, 2015 at 01:55:51PM +0000, Mark Rutland wrote:
> Currently __kvm_hyp_panic uses %p for values which are not pointers,
> such as the ESR value. This can confusingly lead to "(null)" being
> printed for the value.
>
> Use %x instead, and only use %p for host pointers.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Christoffer Dall <christoffer.dall@linaro.org>
Thanks, applied.
-Christoffer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-24 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-16 13:55 [PATCH] arm64: kvm: avoid %p in __kvm_hyp_panic Mark Rutland
2015-11-24 17:18 ` Christoffer Dall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).