From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH 0/3] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions
Date: Tue, 24 Nov 2015 17:51:37 -0800 [thread overview]
Message-ID: <20151125015137.GA11298@codeaurora.org> (raw)
In-Reply-To: <3811106.btnGdZynet@wuerfel>
On 11/24, Arnd Bergmann wrote:
> On Monday 23 November 2015 15:13:52 Stephen Boyd wrote:
> > On 11/23, Arnd Bergmann wrote:
> > >
> > > - PJ4/PJ4B (not PJ4B-MP) has a different custom opcode for udiv and sdiv
> > > in ARM mode. We don't support that with true multiplatform kernels
> > > because those opcodes work nowhere else, though with your proposed
> > > series we could easily do that for dynamic patching.
> >
> > Do you have the information on these custom opcodes? I can work
> > that into the patches assuming the MIDR is different.
>
> Thomas Petazzoni said this in a private mail:
>
> | According to the datasheet, the PJ4B has integer signed and unsigned
> | divide, similar to the sdiv and udiv ARM instructions. But the way to
> | access it is by doing a MRC instruction.
> |
> | MRC<cond> p6, 1, Rd , CRn , CRm, 4
> |
> |for PJ4B is the same as:
> |
> | SDIV Rd , Rn, Rm
> |
> | on ARM cores.
> |
> |And:
> |
> | MRC<cond> p6, 1, Rd , CRn , CRm, 0
> |
> |for PJ4B is the same as:
> |
> | UDIV Rd , Rn, Rm
> |
> |on ARM cores.
> |
> |This is documented in the "Extended instructions" section of the
> |PJ4B datasheet.
>
> I assume what he meant was that this is true for both PJ4 and PJ4B
> but not for PJ4B-MP, which has the normal udiv/sdiv instructions.
>
> IOW, anything with CPU implementer 0x56 part 0x581 should use those,
> while part 0x584 can use the sdiv/udiv that it reports correctly.
>
It looks like we have some sort of function that mostly does
this, except it doesn't differentiate on that lower bit for 1 vs
4. I guess I'll write another one for that.
static inline int cpu_is_pj4(void)
{
unsigned int id;
id = read_cpuid_id();
if ((id & 0xff0fff00) == 0x560f5800)
return 1;
return 0;
}
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-11-25 1:51 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 1:23 [RFC/PATCH 0/3] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions Stephen Boyd
2015-11-21 1:23 ` [RFC/PATCH 1/3] scripts: Allow recordmcount to be used without tracing enabled Stephen Boyd
2015-11-21 1:23 ` [RFC/PATCH 2/3] recordmcount: Record locations of __aeabi_{u}idiv() calls on ARM Stephen Boyd
2015-11-21 10:13 ` Russell King - ARM Linux
2015-11-23 20:53 ` Stephen Boyd
2015-11-23 20:58 ` Steven Rostedt
2015-11-23 21:03 ` Russell King - ARM Linux
2015-11-23 21:16 ` Stephen Boyd
2015-11-23 21:33 ` Russell King - ARM Linux
2015-11-24 1:04 ` Stephen Boyd
2015-11-21 1:23 ` [RFC/PATCH 3/3] ARM: Replace calls to __aeabi_{u}idiv with udiv/sdiv instructions Stephen Boyd
2015-11-21 11:50 ` Måns Rullgård
2015-11-23 20:49 ` Stephen Boyd
2015-11-23 20:54 ` Måns Rullgård
2015-11-23 21:16 ` Stephen Boyd
2015-11-21 20:39 ` [RFC/PATCH 0/3] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions Arnd Bergmann
2015-11-21 20:45 ` Måns Rullgård
2015-11-21 21:00 ` Arnd Bergmann
2015-11-21 22:11 ` Måns Rullgård
2015-11-21 23:14 ` Arnd Bergmann
2015-11-21 23:21 ` Arnd Bergmann
2015-11-22 13:29 ` Peter Maydell
2015-11-22 19:25 ` Arnd Bergmann
2015-11-22 19:30 ` Måns Rullgård
2015-11-22 19:47 ` Russell King - ARM Linux
2015-11-22 19:58 ` Arnd Bergmann
2015-11-22 20:03 ` Russell King - ARM Linux
2015-11-22 20:37 ` Arnd Bergmann
2015-11-22 20:39 ` Måns Rullgård
2015-11-22 21:18 ` Arnd Bergmann
2015-11-23 2:36 ` Nicolas Pitre
2015-11-23 8:15 ` Arnd Bergmann
2015-11-23 14:14 ` Christopher Covington
2015-11-23 15:32 ` Arnd Bergmann
2015-11-23 20:38 ` Stephen Boyd
2015-11-23 21:19 ` Arnd Bergmann
2015-11-23 21:32 ` Stephen Boyd
2015-11-23 21:57 ` Arnd Bergmann
2015-11-23 23:13 ` Stephen Boyd
2015-11-24 10:17 ` Arnd Bergmann
2015-11-24 12:15 ` Måns Rullgård
2015-11-24 13:45 ` Arnd Bergmann
2015-11-25 1:51 ` Stephen Boyd [this message]
2015-11-25 7:21 ` Arnd Bergmann
2015-11-24 0:13 ` Stephen Boyd
2015-11-24 8:53 ` Stephen Boyd
2015-11-24 10:38 ` Arnd Bergmann
2015-11-24 10:42 ` Russell King - ARM Linux
2015-11-24 12:10 ` Måns Rullgård
2015-11-24 12:23 ` Russell King - ARM Linux
2015-11-24 12:29 ` Måns Rullgård
2015-11-24 14:00 ` Russell King - ARM Linux
2015-11-24 14:03 ` Måns Rullgård
2015-11-24 10:39 ` Russell King - ARM Linux
2015-11-24 20:07 ` Stephen Boyd
2015-11-24 20:35 ` Russell King - ARM Linux
2015-11-24 21:11 ` Arnd Bergmann
2016-01-13 1:51 ` Stephen Boyd
2015-11-24 10:37 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151125015137.GA11298@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).