linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 3/3] net: mvneta: Add naive RSS support
Date: Wed, 25 Nov 2015 17:55:22 +0100	[thread overview]
Message-ID: <20151125175522.0e8dd8b8@free-electrons.com> (raw)
In-Reply-To: <1448463243-21057-4-git-send-email-gregory.clement@free-electrons.com>

Gregory,

On Wed, 25 Nov 2015 15:54:03 +0100, Gregory CLEMENT wrote:

>  	pp->rxq_def = rxq_def;
>  
> +	pp->indir[0] = rxq_def;

So now we have the RX queue in both pp->rxq_def and pp->indir[0] ? Is
this really useful ?

Also, if the RX queue becomes a per-port definition, why do you keep
the global rxq_def variable ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-11-25 16:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 14:54 [PATCH net-next 0/3] mvneta: Introduce RSS support Gregory CLEMENT
2015-11-25 14:54 ` [PATCH net-next 1/3] net: mvneta: Make the default queue related for each port Gregory CLEMENT
2015-11-25 14:54 ` [PATCH net-next 2/3] net: mvneta: Associate RX queues with each CPU Gregory CLEMENT
2015-11-25 14:54 ` [PATCH net-next 3/3] net: mvneta: Add naive RSS support Gregory CLEMENT
2015-11-25 16:55   ` Thomas Petazzoni [this message]
2015-11-25 17:08     ` Gregory CLEMENT
2015-11-28 16:43   ` Marcin Wojtas
2015-11-30 16:40     ` Gregory CLEMENT
2015-11-26 19:04 ` [PATCH net-next 0/3] mvneta: Introduce " Marcin Wojtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151125175522.0e8dd8b8@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).