From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: sun4i: Implement MIC1 capture
Date: Mon, 30 Nov 2015 16:17:05 +0000 [thread overview]
Message-ID: <20151130161705.GY1929@sirena.org.uk> (raw)
In-Reply-To: <1448897867-22320-1-git-send-email-maxime.ripard@free-electrons.com>
On Mon, Nov 30, 2015 at 04:37:47PM +0100, Maxime Ripard wrote:
A couple of minor issues below but I'll apply this - please send
followup patches.
> +static void sun4i_codec_start_capture(struct sun4i_codec *scodec)
> +{
> + /*
> + * FIXME: according to the BSP, we might need to drive a PA
> + * GPIO high here on some boards
> + */
That's not something this driver needs to worry about, that's something
the machine driver will do - the whole purpose is to glue all the
different components on the board together.
> + if (clk_set_rate(scodec->clk_module, clk_freq))
> + return -EINVAL;
It'd be better to pass back the error code from clk_set_rate().
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151130/c06aef94/attachment.sig>
next prev parent reply other threads:[~2015-11-30 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 15:37 [PATCH] ASoC: sun4i: Implement MIC1 capture Maxime Ripard
2015-11-30 16:17 ` Mark Brown [this message]
2015-12-01 9:14 ` Maxime Ripard
2015-11-30 16:21 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130161705.GY1929@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).