linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] ARM: dts: DRA7: Add timer12 node
Date: Mon, 30 Nov 2015 10:58:50 -0800	[thread overview]
Message-ID: <20151130185849.GL2517@atomide.com> (raw)
In-Reply-To: <5613F09C.1050809@ti.com>

* Suman Anna <s-anna@ti.com> [151006 09:06]:
> On 10/06/2015 02:52 AM, Tony Lindgren wrote:
> > * Felipe Balbi <balbi@ti.com> [151005 17:51]:
> >>
> >> according to Tony we should avoid using status at all for in-SoC
> >> devices.
> >>
> >> Tony, can you confirm I understood you correctly ?
> > 
> > Yes. With status = "disabled" kernel completely ignores the
> > device and struct device is not created at all even with the
> > device being there. In general we're better off trying to
> > probe the device and idle it.
> > 
> > The only time we really want to mark something with
> > status = "disabled" is if some coprocessor firmware is
> > using that device and the kernel should not touch it at
> > all.
> 
> Not always, since some of the PM clocking logic depends on the state
> machine variables within the kernel.
> 
> We are also using this to deal with paper-spins (atleast in the DRA7
> case) and the DTS include model, wherein certain instances may not be
> present on all variations of the SoC, and enabled specifically on the
> instances that matter. Obviously, it could be done the other way too,
> but as far as what Nishanth mentioned sometime back, we are following
> the former for DRA7.
> 
> In anycase, the status property on the Timer12 node can be removed, it
> doesn't fall into the above category, and we are fixing it up properly
> on HS devices in the kernel.

Yeah please remove the status property, that can be set to disabled
in the HS board specific file.

Applying the first two patches into omap-for-v4.5/soc thanks.

Tony

  reply	other threads:[~2015-11-30 18:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 23:28 [PATCH v2 0/4] DRA7 Timer12 Support Suman Anna
2015-10-05 23:28 ` [PATCH v2 1/4] ARM: OMAP: dmtimer: check for fixed timers during config Suman Anna
2015-10-05 23:28 ` [PATCH v2 2/4] ARM: OMAP2+: timer: Remove secure timer for DRA7xx HS devices Suman Anna
2015-10-05 23:28 ` [PATCH v2 3/4] ARM: dts: DRA7: Add timer12 node Suman Anna
2015-10-06  0:47   ` Felipe Balbi
2015-10-06  7:52     ` Tony Lindgren
2015-10-06 16:02       ` Suman Anna
2015-11-30 18:58         ` Tony Lindgren [this message]
2015-10-05 23:28 ` [PATCH v2 4/4] ARM: DRA7: hwmod: Add data for GPTimer 12 Suman Anna
2015-11-30 18:59   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130185849.GL2517@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).