From mboxrd@z Thu Jan 1 00:00:00 1970 From: computersforpeace@gmail.com (Brian Norris) Date: Mon, 30 Nov 2015 17:56:37 -0800 Subject: [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put In-Reply-To: <1447884254-26336-3-git-send-email-Julia.Lawall@lip6.fr> References: <1447884254-26336-1-git-send-email-Julia.Lawall@lip6.fr> <1447884254-26336-3-git-send-email-Julia.Lawall@lip6.fr> Message-ID: <20151201015637.GW64635@google.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 18, 2015 at 11:04:12PM +0100, Julia Lawall wrote: > for_each_child_of_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local idexpression child; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > ( > return child; > | > + of_node_put(child); > ? return ...; > ) > ... > } > // > > Signed-off-by: Julia Lawall > Pushed to l2-mtd.git