From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: freescale: add ZERO_OFFSET_VALID flag for vf610 pinctrl
Date: Tue, 1 Dec 2015 09:57:10 +0800 [thread overview]
Message-ID: <20151201015707.GA692@tiger> (raw)
In-Reply-To: <1448437251-21487-1-git-send-email-shawnguo@kernel.org>
On Wed, Nov 25, 2015 at 03:40:51PM +0800, Shawn Guo wrote:
> To support i.MX7D Low Power State Retention IOMUXC, commit e7b37a522aa9
> ("pinctrl: freescale: imx: allow mux_reg offset zero") changes the way
> of zero mux_reg offset support with a new flag ZERO_OFFSET_VALID. But,
> unfortunately, it forgot to add this flag for vf610 pinctrl which has
> zero mux_reg offset be valid as well, and hence breaks the vf610
> support.
>
> Fix the regression by adding flag ZERO_OFFSET_VALID for vf610 pinctrl
> driver.
>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> Fixes: e7b37a522aa9 ("pinctrl: freescale: imx: allow mux_reg offset zero")
> Reported-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Andrew Lunn <andrew@lunn.ch>
> Acked-by: Stefan Agner <stefan@agner.ch>
Linus,
Can you help apply the fix for v4.4-rc?
Shawn
> ---
> drivers/pinctrl/freescale/pinctrl-vf610.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-vf610.c b/drivers/pinctrl/freescale/pinctrl-vf610.c
> index 37a037543d29..587d1ff6210e 100644
> --- a/drivers/pinctrl/freescale/pinctrl-vf610.c
> +++ b/drivers/pinctrl/freescale/pinctrl-vf610.c
> @@ -299,7 +299,7 @@ static const struct pinctrl_pin_desc vf610_pinctrl_pads[] = {
> static struct imx_pinctrl_soc_info vf610_pinctrl_info = {
> .pins = vf610_pinctrl_pads,
> .npins = ARRAY_SIZE(vf610_pinctrl_pads),
> - .flags = SHARE_MUX_CONF_REG,
> + .flags = SHARE_MUX_CONF_REG | ZERO_OFFSET_VALID,
> };
>
> static const struct of_device_id vf610_pinctrl_of_match[] = {
> --
> 1.9.1
>
>
next prev parent reply other threads:[~2015-12-01 1:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 7:40 [PATCH] pinctrl: freescale: add ZERO_OFFSET_VALID flag for vf610 pinctrl Shawn Guo
2015-12-01 1:57 ` Shawn Guo [this message]
2015-12-10 17:02 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201015707.GA692@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).