linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v02 04/15] dmaengine: edma: Add support for DMA filter mapping to slave devices
Date: Tue, 1 Dec 2015 22:52:12 +0530	[thread overview]
Message-ID: <20151201172212.GC1696@localhost> (raw)
In-Reply-To: <1448891145-10766-5-git-send-email-peter.ujfalusi@ti.com>

On Mon, Nov 30, 2015 at 03:45:34PM +0200, Peter Ujfalusi wrote:
> Add support for providing device to filter_fn mapping so client drivers
> can switch to use the dma_request_chan() API.

Any reason why we dont want to go with DT based only for edma here?

> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/dma/edma.c                 | 24 ++++++++++++++++++++++++
>  include/linux/platform_data/edma.h |  5 +++++
>  2 files changed, 29 insertions(+)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 0675e268d577..386f8c9bd606 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -2098,6 +2098,8 @@ static struct dma_chan *of_edma_xlate(struct of_phandle_args *dma_spec,
>  }
>  #endif
>  
> +static bool edma_filter_for_map(struct dma_chan *chan, void *param);
> +
>  static int edma_probe(struct platform_device *pdev)
>  {
>  	struct edma_soc_info	*info = pdev->dev.platform_data;
> @@ -2297,6 +2299,12 @@ static int edma_probe(struct platform_device *pdev)
>  		edma_set_chmap(&ecc->slave_chans[i], ecc->dummy_slot);
>  	}
>  
> +	if (info->filter_map) {
> +		ecc->dma_slave.filter_map.map = info->filter_map;
> +		ecc->dma_slave.filter_map.mapcnt = info->filtercnt;
> +		ecc->dma_slave.filter_map.filter_fn = edma_filter_for_map;
> +	}
> +
>  	ret = dma_async_device_register(&ecc->dma_slave);
>  	if (ret) {
>  		dev_err(dev, "slave ddev registration failed (%d)\n", ret);
> @@ -2428,6 +2436,22 @@ bool edma_filter_fn(struct dma_chan *chan, void *param)
>  }
>  EXPORT_SYMBOL(edma_filter_fn);
>  
> +static bool edma_filter_for_map(struct dma_chan *chan, void *param)
> +{
> +	bool match = false;
> +
> +	if (chan->device->dev->driver == &edma_driver.driver) {
> +		struct edma_chan *echan = to_edma_chan(chan);
> +		unsigned ch_req = (unsigned)param;
> +		if (ch_req == echan->ch_num) {
> +			/* The channel is going to be used as HW synchronized */
> +			echan->hw_triggered = true;
> +			match = true;
> +		}
> +	}
> +	return match;
> +}
> +
>  static int edma_init(void)
>  {
>  	int ret;
> diff --git a/include/linux/platform_data/edma.h b/include/linux/platform_data/edma.h
> index e2878baeb90e..117a36d63840 100644
> --- a/include/linux/platform_data/edma.h
> +++ b/include/linux/platform_data/edma.h
> @@ -59,6 +59,8 @@ struct edma_rsv_info {
>  	const s16	(*rsv_slots)[2];
>  };
>  
> +struct dma_filter_map;
> +
>  /* platform_data for EDMA driver */
>  struct edma_soc_info {
>  	/*
> @@ -76,6 +78,9 @@ struct edma_soc_info {
>  
>  	s8	(*queue_priority_mapping)[2];
>  	const s16	(*xbar_chans)[2];
> +
> +	struct dma_filter_map *filter_map;
> +	int filtercnt;
>  };
>  
>  #endif
> -- 
> 2.6.3
> 

-- 
~Vinod

  parent reply	other threads:[~2015-12-01 17:22 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 13:45 [RFC v02 00/15] dmaengine: New 'universal' API for requesting channel Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask() Peter Ujfalusi
2015-11-30 14:35   ` Andy Shevchenko
2015-12-01  9:47     ` Peter Ujfalusi
2015-12-01 12:58       ` Andy Shevchenko
2015-12-01 17:06         ` Vinod Koul
2015-11-30 13:45 ` [RFC v02 02/15] dmaengine: core: Move and merge the code paths using private_candidate Peter Ujfalusi
2015-11-30 14:42   ` Andy Shevchenko
2015-12-01  8:41     ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 03/15] dmaengine: core: Introduce new, universal API to request a channel Peter Ujfalusi
2015-11-30 14:09   ` Arnd Bergmann
2015-12-01  9:48     ` Peter Ujfalusi
2015-11-30 14:51   ` Andy Shevchenko
2015-12-01  9:56     ` Peter Ujfalusi
2015-12-01 10:07       ` Andy Shevchenko
2015-11-30 15:51   ` Tony Lindgren
2015-12-01  8:13     ` Peter Ujfalusi
2015-12-01 17:00       ` Tony Lindgren
2015-12-02 10:00         ` Peter Ujfalusi
2015-12-02 15:00           ` Tony Lindgren
2015-11-30 13:45 ` [RFC v02 04/15] dmaengine: edma: Add support for DMA filter mapping to slave devices Peter Ujfalusi
2015-11-30 14:11   ` Arnd Bergmann
2015-12-01  9:58     ` Peter Ujfalusi
2015-12-01 10:14       ` Arnd Bergmann
2015-12-01 17:22   ` Vinod Koul [this message]
2015-12-01 20:20     ` Arnd Bergmann
2015-12-02  4:37       ` Vinod Koul
2015-12-02 10:02         ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 05/15] ARM: davinci: devices-da8xx: Add dma_filter_map to edma Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 06/15] ARM: davinci: dm355: " Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 07/15] ARM: davinci: dm365: " Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 08/15] ARM: davinci: dm644x: " Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 09/15] ARM: davinci: dm646x: " Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 10/15] mmc: davinci_mmc: Use dma_request_chan() to requesting DMA channel Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 11/15] spi: davinci: " Peter Ujfalusi
2016-05-02 11:04   ` Applied "spi: davinci: Use dma_request_chan() for requesting DMA channel" to the spi tree Mark Brown
2015-11-30 13:45 ` [RFC v02 12/15] ARM: davinci: devices-da8xx: Remove DMA resources for MMC and SPI Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 13/15] ARM: davinci: devices: Remove DMA resources for MMC Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 14/15] ARM: davinci: dm355: Remove DMA resources for SPI Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 15/15] ARM: davinci: dm365: " Peter Ujfalusi
2015-11-30 14:18 ` [RFC v02 00/15] dmaengine: New 'universal' API for requesting channel Arnd Bergmann
2015-12-01 10:12   ` Peter Ujfalusi
2015-12-01 10:15     ` Arnd Bergmann
2015-11-30 14:32 ` Andy Shevchenko
2015-12-01 13:45   ` Peter Ujfalusi
2015-12-01 14:24     ` Arnd Bergmann
2015-12-02 10:51       ` Peter Ujfalusi
2015-12-02 13:38         ` Arnd Bergmann
2015-12-01 16:59 ` Vinod Koul
2015-12-01 20:17   ` Arnd Bergmann
2015-12-02  4:52     ` Vinod Koul
2015-12-02  8:23       ` Arnd Bergmann
2015-12-02 12:29     ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151201172212.GC1696@localhost \
    --to=vinod.koul@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).