* [PATCH] clk: imx: Replace clk error check with imx_check_clocks()
@ 2015-11-26 2:18 Bai Ping
2015-12-01 0:36 ` Stephen Boyd
2015-12-02 6:11 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Bai Ping @ 2015-11-26 2:18 UTC (permalink / raw)
To: linux-arm-kernel
As we already have a 'imx_check_clocks' to do the clock error
check, so cleanup the error check code.
Signed-off-by: Bai Ping <b51503@freescale.com>
---
drivers/clk/imx/clk-imx6ul.c | 4 +---
drivers/clk/imx/clk-imx7d.c | 5 +----
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
index 01718d0..08692d7 100644
--- a/drivers/clk/imx/clk-imx6ul.c
+++ b/drivers/clk/imx/clk-imx6ul.c
@@ -399,9 +399,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
/* mask handshake of mmdc */
writel_relaxed(BM_CCM_CCDR_MMDC_CH0_MASK, base + CCDR);
- for (i = 0; i < ARRAY_SIZE(clks); i++)
- if (IS_ERR(clks[i]))
- pr_err("i.MX6UL clk %d: register failed with %ld\n", i, PTR_ERR(clks[i]));
+ imx_check_clocks(clks, ARRAY_SIZE(clks));
clk_data.clks = clks;
clk_data.clk_num = ARRAY_SIZE(clks);
diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c
index 581b428..fbb6a8c 100644
--- a/drivers/clk/imx/clk-imx7d.c
+++ b/drivers/clk/imx/clk-imx7d.c
@@ -839,10 +839,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node)
clks[IMX7D_PLL_ARM_MAIN_CLK],
clks[IMX7D_PLL_SYS_MAIN_CLK]);
- for (i = 0; i < ARRAY_SIZE(clks); i++)
- if (IS_ERR(clks[i]))
- pr_err("i.MX7D clk %d: register failed with %ld\n",
- i, PTR_ERR(clks[i]));
+ imx_check_clocks(clks, ARRAY_SIZE(clks));
clk_data.clks = clks;
clk_data.clk_num = ARRAY_SIZE(clks);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] clk: imx: Replace clk error check with imx_check_clocks()
2015-11-26 2:18 [PATCH] clk: imx: Replace clk error check with imx_check_clocks() Bai Ping
@ 2015-12-01 0:36 ` Stephen Boyd
2015-12-02 6:11 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2015-12-01 0:36 UTC (permalink / raw)
To: linux-arm-kernel
On 11/26, Bai Ping wrote:
> As we already have a 'imx_check_clocks' to do the clock error
> check, so cleanup the error check code.
>
> Signed-off-by: Bai Ping <b51503@freescale.com>
> ---
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] clk: imx: Replace clk error check with imx_check_clocks()
2015-11-26 2:18 [PATCH] clk: imx: Replace clk error check with imx_check_clocks() Bai Ping
2015-12-01 0:36 ` Stephen Boyd
@ 2015-12-02 6:11 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2015-12-02 6:11 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 26, 2015 at 10:18:43AM +0800, Bai Ping wrote:
> As we already have a 'imx_check_clocks' to do the clock error
> check, so cleanup the error check code.
>
> Signed-off-by: Bai Ping <b51503@freescale.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-02 6:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-26 2:18 [PATCH] clk: imx: Replace clk error check with imx_check_clocks() Bai Ping
2015-12-01 0:36 ` Stephen Boyd
2015-12-02 6:11 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).