* [PATCH v2] ARM: DTS: LS1021A: add SATA node to DTS
@ 2015-11-30 3:39 Yuantian.Tang at freescale.com
2015-12-02 6:30 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Yuantian.Tang at freescale.com @ 2015-11-30 3:39 UTC (permalink / raw)
To: linux-arm-kernel
From: Tang Yuantian <Yuantian.Tang@freescale.com>
Added SATA node to LS1021A DTS to support SATA function.
Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
v2:
- put reg-names right after reg property
arch/arm/boot/dts/ls1021a.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 9430a99..33aae8d 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -143,6 +143,16 @@
status = "disabled";
};
+ sata: sata at 3200000 {
+ compatible = "fsl,ls1021a-ahci";
+ reg = <0x0 0x3200000 0x0 0x10000>,
+ <0x0 0x20220520 0x0 0x4>;
+ reg-names = "ahci", "sata-ecc";
+ interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&platform_clk 1>;
+ dma-coherent;
+ };
+
scfg: scfg at 1570000 {
compatible = "fsl,ls1021a-scfg", "syscon";
reg = <0x0 0x1570000 0x0 0x10000>;
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH v2] ARM: DTS: LS1021A: add SATA node to DTS
2015-11-30 3:39 [PATCH v2] ARM: DTS: LS1021A: add SATA node to DTS Yuantian.Tang at freescale.com
@ 2015-12-02 6:30 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2015-12-02 6:30 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 30, 2015 at 11:39:35AM +0800, Yuantian.Tang at freescale.com wrote:
> From: Tang Yuantian <Yuantian.Tang@freescale.com>
>
> Added SATA node to LS1021A DTS to support SATA function.
>
> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
I think 'ARM: dts: ls1021a: ...' is a more idiomatic patch prefix for
your patch.
> ---
> v2:
> - put reg-names right after reg property
>
> arch/arm/boot/dts/ls1021a.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index 9430a99..33aae8d 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -143,6 +143,16 @@
> status = "disabled";
> };
>
> + sata: sata at 3200000 {
> + compatible = "fsl,ls1021a-ahci";
> + reg = <0x0 0x3200000 0x0 0x10000>,
> + <0x0 0x20220520 0x0 0x4>;
> + reg-names = "ahci", "sata-ecc";
> + interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&platform_clk 1>;
> + dma-coherent;
> + };
Shouldn't it have the line below to get the device disabled in
<soc>.dtsi by default, and let <board>.dts that has sata support to
enable it?
status = "disabled";
Shawn
> +
> scfg: scfg at 1570000 {
> compatible = "fsl,ls1021a-scfg", "syscon";
> reg = <0x0 0x1570000 0x0 0x10000>;
> --
> 2.1.0.27.g96db324
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-02 6:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-30 3:39 [PATCH v2] ARM: DTS: LS1021A: add SATA node to DTS Yuantian.Tang at freescale.com
2015-12-02 6:30 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).