linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: config: Regenerate multi_v5_defconfig
Date: Wed, 2 Dec 2015 16:08:01 +0100	[thread overview]
Message-ID: <20151202150801.GL29814@lunn.ch> (raw)
In-Reply-To: <2115626.l90A97hBkH@wuerfel>

On Wed, Dec 02, 2015 at 03:57:01PM +0100, Arnd Bergmann wrote:
> On Wednesday 02 December 2015 15:17:56 Andrew Lunn wrote:
> > On Wed, Dec 02, 2015 at 02:44:00PM +0100, Arnd Bergmann wrote:
> > > On Wednesday 02 December 2015 00:33:28 Andrew Lunn wrote:
> > > > Dues the Kconfig changes, multi_v5_defconfig needs regenerating.
> > > > 
> > > > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > > > ---
> > > >  arch/arm/configs/multi_v5_defconfig | 17 ++++-------------
> > > >  1 file changed, 4 insertions(+), 13 deletions(-)
> > > > 
> > > > diff --git a/arch/arm/configs/multi_v5_defconfig b/arch/arm/configs/multi_v5_defconfig
> > > > index f69a459f4f92..f98d4b8b54c5 100644
> > > > --- a/arch/arm/configs/multi_v5_defconfig
> > > > +++ b/arch/arm/configs/multi_v5_defconfig
> > > > @@ -11,10 +11,9 @@ CONFIG_MODULE_UNLOAD=y
> > > > @@ -53,7 +52,6 @@ CONFIG_MTD_CFI_GEOMETRY=y
> > > >  CONFIG_MTD_CFI_INTELEXT=y
> > > >  CONFIG_MTD_CFI_STAA=y
> > > >  CONFIG_MTD_PHYSMAP=y
> > > > -CONFIG_MTD_M25P80=y
> > > 
> > > I think we need to enable MTD_SPI_NOR_BASE now to get the driver
> > > back, see 03e296f613af ("mtd: m25p80: use the SPI nor framework")
> > 
> > As you noticed, this is a pure regenerate.
> > 
> > I will send a few more followups with the MTD_SPI_NOR_BASE, and
> > dropping EXT[23].
> 
> Maybe you can do those changes first and regenerate afterwards?
> 
> That makes it more obvious what's going on than removing a symbol
> first and then putting it back.

The flip side is that the regenerate makes it reflect reality. Those
options actually are disabled in todays kernel.

Also, doing it the other way around is quite a bit of work, since you
have to manually edit the _defconfig and figure out manually where the
option needs to be placed in the file.

Humm, i wounder if 0-day could be of use here. How about at the end of
each patch series, it regenerates the _defconfig files. If there are
any changes, issue a warning. That will help keep them in sync with
reality.

	Andrew

  reply	other threads:[~2015-12-02 15:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 23:33 [PATCH 0/5] multi and mvebu v5 defconfig updates Andrew Lunn
2015-12-01 23:33 ` [PATCH 1/5] ARM: config: Regenerate multi_v5_defconfig Andrew Lunn
2015-12-02 13:44   ` Arnd Bergmann
2015-12-02 14:17     ` Andrew Lunn
2015-12-02 14:57       ` Arnd Bergmann
2015-12-02 15:08         ` Andrew Lunn [this message]
2015-12-02 15:10           ` Arnd Bergmann
2015-12-01 23:33 ` [PATCH 2/5] ARM: config: Reenable DSA in multi_v5_defconfig Andrew Lunn
2015-12-02 13:44   ` Arnd Bergmann
2015-12-01 23:33 ` [PATCH 3/5] ARM: config: Add orion5x to multi_v5_defconfig Andrew Lunn
2015-12-01 23:33 ` [PATCH 4/5] ARM: mvebu: Reenable DSA in mvebu_v5_defconfig Andrew Lunn
2015-12-07 17:02   ` Gregory CLEMENT
2015-12-01 23:33 ` [PATCH 5/5] ARM: mvebu: update v5 defconfig for Orion5x machines Andrew Lunn
2015-12-07 17:03   ` Gregory CLEMENT
2015-12-07 17:06 ` [PATCH 0/5] multi and mvebu v5 defconfig updates Gregory CLEMENT
2015-12-07 22:57   ` Arnd Bergmann
2015-12-08  9:55     ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151202150801.GL29814@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).