public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] rk3368 idle states
Date: Thu, 3 Dec 2015 10:11:28 +0000	[thread overview]
Message-ID: <20151203101128.GB2110@red-moon> (raw)
In-Reply-To: <2472961.2QZIyIIJQ0@diego>

Hi Heiko,

On Thu, Dec 03, 2015 at 02:05:01AM +0100, Heiko St?bner wrote:
> Hi Lorenzo,
> 
> Am Mittwoch, 2. Dezember 2015, 11:18:58 schrieb Lorenzo Pieralisi:
> > while reviewing other dts idle states bindings I spotted the following
> > snippet in arch/arm64/boot/dts/rockchip/rk3368.dtsi:
> > 
> > cpu_sleep: cpu-sleep-0 {
> >        compatible = "arm,idle-state";
> >        arm,psci-suspend-param = <0x1010000>;
> >        entry-latency-us = <0x3fffffff>;
> >        exit-latency-us = <0x40000000>;
> >        min-residency-us = <0xffffffff>;
> > };
> > 
> > Could you please explain to me how you obtained these residency/latency
> > values ? They make NO sense whatsoever and I am quite tempted to
> > ask you to remove this data from the dts file, it is just wrong.
> 
> I took these values verbatim from the vendor kernel when adding the core 
> rk3368 support.
> 
> I guess I was overly enthusiastic, that psci worked out of the box for smp, 
> that I didn't check the latency/residency values enough at that time. As time-
> values they are really overly long :-) .
> 
> 
> Nevertheless I have inquired now, what the background of those values is.

Thank you, they must be updated, hopefully they won't unearth any issue
with the idle state - ie at present the idle state simply turns out unused.

Lorenzo

      reply	other threads:[~2015-12-03 10:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 11:18 [RFC] rk3368 idle states Lorenzo Pieralisi
2015-12-03  1:05 ` Heiko Stübner
2015-12-03 10:11   ` Lorenzo Pieralisi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151203101128.GB2110@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox