linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rostedt@goodmis.org (Steven Rostedt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] arm64: ftrace: stop using kstop_machine to enable/disable tracing
Date: Thu, 3 Dec 2015 22:12:41 -0500	[thread overview]
Message-ID: <20151203221241.07ff092e@grimm.local.home> (raw)
In-Reply-To: <1449195519-17901-2-git-send-email-huawei.libin@huawei.com>

On Fri, 4 Dec 2015 10:18:38 +0800
Li Bin <huawei.libin@huawei.com> wrote:

> For ftrace on arm64, kstop_machine which is hugely disruptive
> to a running system is not needed to convert nops to ftrace calls
> or back, because that to be modified instrucions, that NOP, B or BL,
> are all safe instructions which called "concurrent modification
> and execution of instructions", that can be executed by one
> thread of execution as they are being modified by another thread
> of execution without requiring explicit synchronization.
> 
> Signed-off-by: Li Bin <huawei.libin@huawei.com>
> ---
>  arch/arm64/kernel/ftrace.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm64/kernel/ftrace.c b/arch/arm64/kernel/ftrace.c
> index c851be7..9669b33 100644
> --- a/arch/arm64/kernel/ftrace.c
> +++ b/arch/arm64/kernel/ftrace.c
> @@ -93,6 +93,11 @@ int ftrace_make_nop(struct module *mod, struct dyn_ftrace *rec,
>  	return ftrace_modify_code(pc, old, new, true);
>  }
>  
> +void arch_ftrace_update_code(int command)
> +{
> +	ftrace_modify_all_code(command);

Hmm, I wonder why I haven't done this for powerpc. I probably should.

Anyway,

Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

If it is indeed safe not to do any special handling.

-- Steve

> +}
> +
>  int __init ftrace_dyn_arch_init(void)
>  {
>  	return 0;

  reply	other threads:[~2015-12-04  3:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  2:18 [PATCH v2 0/2] arm64: stop using kstop_machine for ftrace Li Bin
2015-12-04  2:18 ` [PATCH v2 1/2] arm64: ftrace: stop using kstop_machine to enable/disable tracing Li Bin
2015-12-04  3:12   ` Steven Rostedt [this message]
2015-12-04  2:18 ` [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code Li Bin
2015-12-04  2:50   ` Steven Rostedt
2015-12-04  3:23     ` Li Bin
2015-12-04  6:36     ` Li Bin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151203221241.07ff092e@grimm.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).