* [PATCH 0/2] phy: berlin-usb: clean up
@ 2015-12-04 13:56 Jisheng Zhang
2015-12-04 13:57 ` [PATCH 1/2] phy: berlin-usb: remove non-necessary header files Jisheng Zhang
2015-12-04 13:57 ` [PATCH 2/2] phy: berlin-usb: don't set device's driver_data Jisheng Zhang
0 siblings, 2 replies; 5+ messages in thread
From: Jisheng Zhang @ 2015-12-04 13:56 UTC (permalink / raw)
To: linux-arm-kernel
trivial patches to do some clean up: remove non-necessary header files
and remove useless platform_set_drvdata() calling.
Jisheng Zhang (2):
phy: berlin-usb: remove non-necessary header files
phy: berlin-usb: don't set device's driver_data
drivers/phy/phy-berlin-usb.c | 3 ---
1 file changed, 3 deletions(-)
--
2.6.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] phy: berlin-usb: remove non-necessary header files
2015-12-04 13:56 [PATCH 0/2] phy: berlin-usb: clean up Jisheng Zhang
@ 2015-12-04 13:57 ` Jisheng Zhang
2015-12-04 21:08 ` Antoine Tenart
2015-12-04 13:57 ` [PATCH 2/2] phy: berlin-usb: don't set device's driver_data Jisheng Zhang
1 sibling, 1 reply; 5+ messages in thread
From: Jisheng Zhang @ 2015-12-04 13:57 UTC (permalink / raw)
To: linux-arm-kernel
We don't need gpio related header files, so remove them.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/phy/phy-berlin-usb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
index 797ba17..7bbb473 100644
--- a/drivers/phy/phy-berlin-usb.c
+++ b/drivers/phy/phy-berlin-usb.c
@@ -9,11 +9,9 @@
* warranty of any kind, whether express or implied.
*/
-#include <linux/gpio.h>
#include <linux/io.h>
#include <linux/module.h>
#include <linux/of_device.h>
-#include <linux/of_gpio.h>
#include <linux/phy/phy.h>
#include <linux/platform_device.h>
#include <linux/reset.h>
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] phy: berlin-usb: don't set device's driver_data
2015-12-04 13:56 [PATCH 0/2] phy: berlin-usb: clean up Jisheng Zhang
2015-12-04 13:57 ` [PATCH 1/2] phy: berlin-usb: remove non-necessary header files Jisheng Zhang
@ 2015-12-04 13:57 ` Jisheng Zhang
2015-12-04 21:09 ` Antoine Tenart
1 sibling, 1 reply; 5+ messages in thread
From: Jisheng Zhang @ 2015-12-04 13:57 UTC (permalink / raw)
To: linux-arm-kernel
After commit 739ae3452d0e ("phy: berlin-usb: Set drvdata for phy and
use it"), we get the address of priv by phy_get_drvdata(), so there's
no need to set device's driver_data any more. This patch removes the
call of platform_set_drvdata().
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/phy/phy-berlin-usb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
index 7bbb473..2017751 100644
--- a/drivers/phy/phy-berlin-usb.c
+++ b/drivers/phy/phy-berlin-usb.c
@@ -193,7 +193,6 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
return PTR_ERR(phy);
}
- platform_set_drvdata(pdev, priv);
phy_set_drvdata(phy, priv);
phy_provider =
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/2] phy: berlin-usb: remove non-necessary header files
2015-12-04 13:57 ` [PATCH 1/2] phy: berlin-usb: remove non-necessary header files Jisheng Zhang
@ 2015-12-04 21:08 ` Antoine Tenart
0 siblings, 0 replies; 5+ messages in thread
From: Antoine Tenart @ 2015-12-04 21:08 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 04, 2015 at 09:57:00PM +0800, Jisheng Zhang wrote:
> We don't need gpio related header files, so remove them.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/phy/phy-berlin-usb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 797ba17..7bbb473 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -9,11 +9,9 @@
> * warranty of any kind, whether express or implied.
> */
>
> -#include <linux/gpio.h>
> #include <linux/io.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
> #include <linux/phy/phy.h>
> #include <linux/platform_device.h>
> #include <linux/reset.h>
> --
> 2.6.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151204/91f484a2/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] phy: berlin-usb: don't set device's driver_data
2015-12-04 13:57 ` [PATCH 2/2] phy: berlin-usb: don't set device's driver_data Jisheng Zhang
@ 2015-12-04 21:09 ` Antoine Tenart
0 siblings, 0 replies; 5+ messages in thread
From: Antoine Tenart @ 2015-12-04 21:09 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 04, 2015 at 09:57:01PM +0800, Jisheng Zhang wrote:
> After commit 739ae3452d0e ("phy: berlin-usb: Set drvdata for phy and
> use it"), we get the address of priv by phy_get_drvdata(), so there's
> no need to set device's driver_data any more. This patch removes the
> call of platform_set_drvdata().
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/phy/phy-berlin-usb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 7bbb473..2017751 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -193,7 +193,6 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> return PTR_ERR(phy);
> }
>
> - platform_set_drvdata(pdev, priv);
> phy_set_drvdata(phy, priv);
>
> phy_provider =
> --
> 2.6.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151204/113bb1d5/attachment-0001.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-04 21:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-04 13:56 [PATCH 0/2] phy: berlin-usb: clean up Jisheng Zhang
2015-12-04 13:57 ` [PATCH 1/2] phy: berlin-usb: remove non-necessary header files Jisheng Zhang
2015-12-04 21:08 ` Antoine Tenart
2015-12-04 13:57 ` [PATCH 2/2] phy: berlin-usb: don't set device's driver_data Jisheng Zhang
2015-12-04 21:09 ` Antoine Tenart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).