From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3
Date: Fri, 4 Dec 2015 13:51:15 -0800 [thread overview]
Message-ID: <20151204215115.GP23396@atomide.com> (raw)
In-Reply-To: <5617214.abxPrpfVaF@wuerfel>
* Arnd Bergmann <arnd@arndb.de> [151204 13:38]:
> On Friday 04 December 2015 10:47:07 Tony Lindgren wrote:
> > > Peter Ujfalusi <peter.ujfalusi@ti.com> writes:
> > > > @@ -174,12 +182,44 @@
> > > > };
> > > >
> > > > edma: edma at 49000000 {
> > > > - compatible = "ti,edma3";
> > > > - ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2";
> > > > - reg = <0x49000000 0x10000>,
> > > > - <0x44e10f90 0x40>;
> > > > + compatible = "ti,edma3-tpcc";
> > > > + ti,hwmods = "tpcc";
> > > > + reg = <0x49000000 0x10000>;
> > > > + reg-names = "edma3_cc";
> > > > interrupts = <12 13 14>;
> > > > - #dma-cells = <1>;
> > > > + interrupt-names = "edma3_ccint", "emda3_mperr",
> > > > + "edma3_ccerrint";
> > > > + dma-requests = <64>;
> > > > + #dma-cells = <2>;
> > > > +
> > > > + ti,tptcs = <&edma_tptc0 7>, <&edma_tptc1 5>,
> > > > + <&edma_tptc2 0>;
> > > > +
> > > > + ti,edma-memcpy-channels = /bits/ 16 <20 21>;
> > >
> > > can you explain this property here ? Are you setting bits 20 and 21 on a
> > > 16-bit field ?
> >
> > I think it's an arry of u16 dma channels.. But could it be just /bits/ 8
> > instead of /bits/ 16?
> >
>
> Please just drop the /bits/ 16 and use normal cells.
Yeah agreed, makes things less confusing for sure :)
Tony
next prev parent reply other threads:[~2015-12-04 21:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 10:45 [PATCH] ARM: DTS: am33xx: Use the new DT bindings for the eDMA3 Peter Ujfalusi
2015-12-04 17:21 ` Felipe Balbi
2015-12-04 18:47 ` Tony Lindgren
2015-12-04 21:36 ` Arnd Bergmann
2015-12-04 21:51 ` Tony Lindgren [this message]
2015-12-08 7:42 ` Peter Ujfalusi
2015-12-08 9:51 ` Arnd Bergmann
2015-12-08 10:22 ` Peter Ujfalusi
2015-12-08 10:25 ` Arnd Bergmann
2015-12-08 15:51 ` Tony Lindgren
2015-12-08 0:19 ` Tony Lindgren
2015-12-08 7:43 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204215115.GP23396@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).