From: soren.brinkmann@xilinx.com (Sören Brinkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH LINUX v3 08/10] tty: xuartps: Move RX path into helper function
Date: Sat, 5 Dec 2015 13:49:21 -0800 [thread overview]
Message-ID: <20151205214921.GN4900@xsjsorenbubuntu> (raw)
In-Reply-To: <56632177.1090605@hurleysoftware.com>
On Sat, 2015-12-05 at 12:40PM -0500, Peter Hurley wrote:
> On 11/21/2015 09:59 PM, Soren Brinkmann wrote:
> > Move RX-related IRQ handling into a helper function.
> Fixes a problem where every char received after a parity or frame error
> in the current isr will also be tagged as a parity or frame error.
>
> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Thanks. I'll add your text to the commit message.
>
> NB: the sysrq problem in cdns_uart_isr() with needing to drop the
> locks is because cdns_uart_console_write() tries to take the port->lock.
> The 8250 driver handles this problem by not trying to take the
> port->lock if port->sysrq is non-zero. See serial8250_console_write().
I'll look into this. I'll see if I can include that in the next
iteration of this series or do it later.
Thanks,
S?ren
next prev parent reply other threads:[~2015-12-05 21:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 2:59 [PATCH LINUX v3 00/10] tty: xuartps: Fix lock ups Soren Brinkmann
2015-11-22 2:59 ` [PATCH LINUX v3 01/10] tty: xuartps: Beautify read-modify writes Soren Brinkmann
2015-12-05 17:04 ` Peter Hurley
2015-12-05 17:23 ` Moritz Fischer
2015-11-22 2:59 ` [PATCH LINUX v3 02/10] tty: xuartps: Use spinlock to serialize HW access Soren Brinkmann
2015-12-05 17:05 ` Peter Hurley
2015-11-22 2:59 ` [PATCH LINUX v3 03/10] tty: xuartps: Don't consider circular buffer when enabling transmitter Soren Brinkmann
2015-12-05 17:17 ` Peter Hurley
2015-11-22 2:59 ` [PATCH LINUX v3 04/10] tty: xuartps: Clear interrupt status register in shutdown Soren Brinkmann
2015-12-05 17:19 ` Peter Hurley
2015-12-05 17:25 ` Moritz Fischer
2015-11-22 2:59 ` [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function Soren Brinkmann
2015-12-05 17:21 ` Peter Hurley
2015-12-05 21:47 ` Sören Brinkmann
2015-11-22 2:59 ` [PATCH LINUX v3 06/10] tty: xuartps: Keep lock for whole ISR Soren Brinkmann
2015-12-05 17:23 ` Peter Hurley
2015-11-22 2:59 ` [PATCH LINUX v3 07/10] tty: xuartps: Acquire port lock for shutdown Soren Brinkmann
2015-12-05 17:23 ` Peter Hurley
2015-11-22 2:59 ` [PATCH LINUX v3 08/10] tty: xuartps: Move RX path into helper function Soren Brinkmann
2015-12-05 17:40 ` Peter Hurley
2015-12-05 21:49 ` Sören Brinkmann [this message]
2015-11-22 2:59 ` [PATCH LINUX v3 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled Soren Brinkmann
2015-12-05 17:43 ` Peter Hurley
2015-12-05 22:19 ` Sören Brinkmann
2015-11-22 2:59 ` [PATCH LINUX v3 10/10] tty: xuartps: Cleanup: Reformat if-else Soren Brinkmann
2015-12-05 17:49 ` [PATCH LINUX v3 00/10] tty: xuartps: Fix lock ups Peter Hurley
2015-12-05 22:02 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151205214921.GN4900@xsjsorenbubuntu \
--to=soren.brinkmann@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox