From: panand@redhat.com (Pratyush Anand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] kexec: Add --lite option
Date: Mon, 7 Dec 2015 17:18:39 +0530 [thread overview]
Message-ID: <20151207114839.GF16406@dhcppc13.redhat.com> (raw)
In-Reply-To: <20151207114547.GE16406@dhcppc13.redhat.com>
Sorry, forgot to add linux-arm-kernel at lists.infradead.org. Now CCed.
On 07/12/2015:05:15:47 PM, Pratyush Anand wrote:
> +linux-arm-kernel at lists.infradead.org (May be someone from arm kernel list can
> give some more input)
>
> On 04/11/2015:11:56:51 PM, Scott Wood wrote:
> > On Thu, 2015-10-22 at 12:08 -0700, Geoff Levand wrote:
> > > I notice the difference on the my arm64 system, so I guess we
> > > are even on that.
> >
> > For me it was beyond "notice the difference" -- I thought it was completely
> > broken, and was preparing to debug, until it started spitting out output over
> > a minute later.
> >
> > Compiling the sha256 code with -O2 instead of -O0 cut it down to around 10
> > seconds (still unpleasant, but not quite as crazy... still unacceptable for
> > non-kdump, though).
>
> Yes, compiling purgatory code with -O2 helps to improve the timing, and I notice
> that enabling D-cache on top of -O2 does not improve it further. However, I am
> still not able to understand that why there is huge difference between following
> two.
>
> 1) When we execute kexec() system call in first kernel, at that time it
> calculates sha256 on all the binaries [1]. It take almost un-noticeable time
> (less than a sec) there.
>
> 2) When purgatory is executed then it re-calculates sha256 using same routines
> [2] on same binary data as that of case (1). But, now it takes 10-20 sec
> (depending of size of binaries)?
>
> Why did not it take same time with O2 + D-cache enabled? I think, we should be
> able to achieve same time in second case as well. What is missing?
>
> ~Pratyush
>
> [1] http://git.kernel.org/cgit/utils/kernel/kexec/kexec-tools.git/tree/kexec/kexec.c#n650
> [2] http://git.kernel.org/cgit/utils/kernel/kexec/kexec-tools.git/tree/purgatory/purgatory.c#n20
next parent reply other threads:[~2015-12-07 11:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1445469125.30908.105.camel@infradead.org>
[not found] ` <20151022031718.GB11227@dhcp-129-115.nay.redhat.com>
[not found] ` <20151022125012.GB20847@redhat.com>
[not found] ` <1445540891.30908.144.camel@infradead.org>
[not found] ` <1446703011.12676.83.camel@freescale.com>
[not found] ` <20151207114547.GE16406@dhcppc13.redhat.com>
2015-12-07 11:48 ` Pratyush Anand [this message]
2015-12-07 13:16 ` [PATCH] kexec: Add --lite option James Morse
2015-12-07 14:07 ` Pratyush Anand
2015-12-08 1:03 ` Scott Wood
2015-12-08 16:00 ` James Morse
2015-12-09 9:28 ` Pratyush Anand
2016-01-11 12:46 ` Pratyush Anand
2016-01-12 1:06 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207114839.GF16406@dhcppc13.redhat.com \
--to=panand@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).