From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: sunxi: Extend the simple gates and handle the Allwinner H3
Date: Mon, 7 Dec 2015 08:31:02 -0600 [thread overview]
Message-ID: <20151207143102.GA29097@rob-hp-laptop> (raw)
In-Reply-To: <20151206100412.1a74b71da8e9ca28c6e61589@free.fr>
On Sun, Dec 06, 2015 at 10:04:12AM +0100, Jean-Francois Moine wrote:
> The H3 has a clock gate definition similar to the other Allwinner SoCs,
> but with a different parent clock for each single gate.
>
> Adding the names of the parent clocks in both the source and output clocks
> permits the use of the simple-gates driver to define the bus gates
> of all known Allwinner SoCs.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
> This patch replaces a part of Jens Kuske's patch
> [PATCH v5 1/4] clk: sunxi: Add H3 clocks support
> ---
> Documentation/devicetree/bindings/clock/sunxi.txt | 25 +++++++++++++++++++++++
> drivers/clk/sunxi/clk-simple-gates.c | 14 ++++++++++++-
> 2 files changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/sunxi.txt b/Documentation/devicetree/bindings/clock/sunxi.txt
> index 8a47b77..5736e6d 100644
> --- a/Documentation/devicetree/bindings/clock/sunxi.txt
> +++ b/Documentation/devicetree/bindings/clock/sunxi.txt
> @@ -70,6 +70,7 @@ Required properties:
> "allwinner,sun8i-a23-usb-clk" - for usb gates + resets on A23
> "allwinner,sun9i-a80-usb-mod-clk" - for usb gates + resets on A80
> "allwinner,sun9i-a80-usb-phy-clk" - for usb phy gates + resets on A80
> + "allwinner,sunxi-gates-clk" - simple gates
>
> Required properties for all clocks:
> - reg : shall be the control register address for the clock.
> @@ -93,6 +94,12 @@ The "allwinner,sun9i-a80-mmc-config-clk" clock also requires:
> - #reset-cells : shall be set to 1
> - resets : shall be the reset control phandle for the mmc block.
>
> +The "allwinner,sunxi-gates-clk" clock also requires:
> +- clock-names : corresponding names of the parent clocks
> +when the output clocks have different parents.
> +These names must be 4 characters long and must appear as a prefix in
> +the names of the output clocks. See example.
> +
I don't think you should be encoding relationships of clocks using the
name strings. We describe relationships in DT via parent/child or
phandles.
Rob
next prev parent reply other threads:[~2015-12-07 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 9:04 [PATCH] clk: sunxi: Extend the simple gates and handle the Allwinner H3 Jean-Francois Moine
2015-12-07 14:31 ` Rob Herring [this message]
2015-12-08 6:42 ` Jean-Francois Moine
2015-12-08 7:53 ` Maxime Ripard
2015-12-08 8:09 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207143102.GA29097@rob-hp-laptop \
--to=robh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox