From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] cpufreq: mt8173: move resources allocation into ->probe()
Date: Mon, 7 Dec 2015 21:33:57 +0530 [thread overview]
Message-ID: <20151207160357.GL3294@ubuntu> (raw)
In-Reply-To: <CALx668XbV2CbuB0QL_3eV=JMTeOyjKP=s2mznadQxgGD_SGABg@mail.gmail.com>
On 07-12-15, 20:42, Pi-Cheng Chen wrote:
> >> ret = dev_pm_opp_init_cpufreq_table(info->cpu_dev, &freq_table);
> >
> > Hmm. Does this change at init() time? Or can we move this to probe(), too?
>
> It doesn't change at init() time for MT8173 since we don't add OPP
> dynamically and I don't see any problem to move it. I will move it to probe().
No. None of this belongs to probe(), we do it there just to handle the
EPROBE_DEFER thing. Please don't move anything that isn't required to
be.
--
viresh
next prev parent reply other threads:[~2015-12-07 16:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-29 8:31 [PATCH 1/4] cpufreq: mt8173: add CPUFREQ_HAVE_GOVERNOR_PER_POLICY flag Pi-Cheng Chen
2015-11-29 8:31 ` [PATCH 2/4] cpufreq: mt8173: remove redundant regulator_get_voltage() call Pi-Cheng Chen
2015-11-30 5:23 ` Viresh Kumar
2015-11-29 8:31 ` [PATCH 3/4] cpufreq: mt8173: check return value of " Pi-Cheng Chen
2015-11-30 5:27 ` Viresh Kumar
2015-11-29 8:31 ` [PATCH 4/4] cpufreq: mt8173: move resources allocation into ->probe() Pi-Cheng Chen
2015-12-05 6:01 ` [PATCH v2] " Pi-Cheng Chen
2015-12-06 2:24 ` Viresh Kumar
2015-12-07 2:44 ` Daniel Kurtz
2015-12-07 12:42 ` Pi-Cheng Chen
2015-12-07 16:03 ` Viresh Kumar [this message]
2015-12-09 23:53 ` Rafael J. Wysocki
2015-12-10 3:48 ` [PATCH v3] " Pi-Cheng Chen
2015-12-14 23:59 ` Rafael J. Wysocki
2015-11-30 5:20 ` [PATCH 1/4] cpufreq: mt8173: add CPUFREQ_HAVE_GOVERNOR_PER_POLICY flag Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207160357.GL3294@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).