From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Tue, 8 Dec 2015 11:33:43 +0100 Subject: [PATCH 05/23] mtd: nand: jz4770: kill the ->ecc_layout field In-Reply-To: <5666B150.2030406@imgtec.com> References: <1449527178-5930-1-git-send-email-boris.brezillon@free-electrons.com> <1449527178-5930-6-git-send-email-boris.brezillon@free-electrons.com> <5666B150.2030406@imgtec.com> Message-ID: <20151208113343.2b049993@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 8 Dec 2015 10:30:40 +0000 Harvey Hunt wrote: > Hi Boris, > > On 07/12/15 22:26, Boris Brezillon wrote: > > ->ecc_layout is not used by any board file. Kill this field to avoid any > > confusion. New boards are encouraged to use the default ECC layout defined > > in NAND core. > > > > Signed-off-by: Boris Brezillon > > --- > > arch/mips/include/asm/mach-jz4740/jz4740_nand.h | 2 -- > > drivers/mtd/nand/jz4740_nand.c | 3 --- > > 2 files changed, 5 deletions(-) > > > > diff --git a/arch/mips/include/asm/mach-jz4740/jz4740_nand.h b/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > > index 79cff26..398733e 100644 > > --- a/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > > +++ b/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > > @@ -25,8 +25,6 @@ struct jz_nand_platform_data { > > int num_partitions; > > struct mtd_partition *partitions; > > > > - struct nand_ecclayout *ecc_layout; > > - > > unsigned char banks[JZ_NAND_NUM_BANKS]; > > > > void (*ident_callback)(struct platform_device *, struct nand_chip *, > > diff --git a/drivers/mtd/nand/jz4740_nand.c b/drivers/mtd/nand/jz4740_nand.c > > index 5a99a93..c4fe446 100644 > > --- a/drivers/mtd/nand/jz4740_nand.c > > +++ b/drivers/mtd/nand/jz4740_nand.c > > @@ -446,9 +446,6 @@ static int jz_nand_probe(struct platform_device *pdev) > > chip->ecc.bytes = 9; > > chip->ecc.strength = 4; > > > > - if (pdata) > > - chip->ecc.layout = pdata->ecc_layout; > > - > > chip->chip_delay = 50; > > chip->cmd_ctrl = jz_nand_cmd_ctrl; > > chip->select_chip = jz_nand_select_chip; > > > > Is there a typo in this commit title? The JZ4740 and JZ4770 have quite > different NAND controller interfaces, so I don't think that the JZ4740 > driver will support the JZ4770. Yes, it's a typo, I meant jz4740, I'll fix my commit message accordingly. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com