From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: spinlock: serialise spin_unlock_wait against concurrent lockers
Date: Fri, 11 Dec 2015 09:46:52 +0000 [thread overview]
Message-ID: <20151211094651.GA18828@arm.com> (raw)
In-Reply-To: <20151211080911.GD1072@fixme-laptop.cn.ibm.com>
On Fri, Dec 11, 2015 at 04:09:11PM +0800, Boqun Feng wrote:
> In conclusion, we have more than a half of uses working well already,
> and each of the fix-needed ones has only one related critical section
> and only one related data access in it. So on PPC, I think my proposal
> won't have more smp_mb() instances to fix all current use cases than
> adding smp_mb__after_unlock_lock() after the lock acquisition in each
> related lock critical section.
>
> Of course, my proposal needs the buy-ins of both PPC and ARM64v8, so
> Paul and Will, what do you think? ;-)
I already queued the change promoting it to LOCK for arm64. It makes the
semantics easy to understand and I've failed to measure any difference
in performance. It's also robust against any future users of the macro
and matches what other architectures do.
Will
next prev parent reply other threads:[~2015-12-11 9:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 11:44 [PATCH] arm64: spinlock: serialise spin_unlock_wait against concurrent lockers Will Deacon
2015-11-30 15:58 ` Peter Zijlstra
2015-11-30 18:21 ` Paul E. McKenney
2015-12-01 16:40 ` Will Deacon
2015-12-03 0:11 ` Paul E. McKenney
2015-12-03 13:28 ` Peter Zijlstra
2015-12-03 16:32 ` Will Deacon
2015-12-03 17:22 ` Paul E. McKenney
2015-12-04 9:21 ` Peter Zijlstra
2015-12-04 16:07 ` Paul E. McKenney
2015-12-04 16:24 ` Will Deacon
2015-12-04 16:44 ` Paul E. McKenney
2015-12-06 7:37 ` Boqun Feng
2015-12-06 19:23 ` Paul E. McKenney
2015-12-06 23:28 ` Boqun Feng
2015-12-07 0:00 ` Paul E. McKenney
2015-12-07 0:45 ` Boqun Feng
2015-12-07 10:34 ` Peter Zijlstra
2015-12-07 15:45 ` Paul E. McKenney
2015-12-08 8:42 ` Boqun Feng
2015-12-08 19:17 ` Paul E. McKenney
2015-12-09 6:43 ` Boqun Feng
2015-12-04 9:36 ` Peter Zijlstra
2015-12-04 16:13 ` Paul E. McKenney
2015-12-07 2:12 ` Michael Ellerman
2015-12-06 8:16 ` Boqun Feng
2015-12-06 19:27 ` Paul E. McKenney
2015-12-07 0:26 ` Boqun Feng
2015-12-11 8:09 ` Boqun Feng
2015-12-11 9:46 ` Will Deacon [this message]
2015-12-11 12:20 ` Boqun Feng
2015-12-11 13:42 ` Paul E. McKenney
2015-12-11 13:54 ` Will Deacon
2015-12-01 0:40 ` Boqun Feng
2015-12-01 16:32 ` Will Deacon
2015-12-02 9:40 ` Boqun Feng
2015-12-02 11:16 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211094651.GA18828@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).