public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/7] clk: hisilicon: add dt-binding document for Hi3519 CRG
Date: Fri, 11 Dec 2015 09:19:09 -0600	[thread overview]
Message-ID: <20151211151909.GA21272@rob-hp-laptop> (raw)
In-Reply-To: <1449819921-18464-3-git-send-email-xuejiancheng@huawei.com>

On Fri, Dec 11, 2015 at 03:45:16PM +0800, Jiancheng Xue wrote:
> add dt-binding document for Hi3519 CRG block
> 
> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
> ---
>  .../devicetree/bindings/clock/hi3519-crg.txt       | 46 ++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/hi3519-crg.txt
> 
> diff --git a/Documentation/devicetree/bindings/clock/hi3519-crg.txt b/Documentation/devicetree/bindings/clock/hi3519-crg.txt
> new file mode 100644
> index 0000000..e0d30a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/hi3519-crg.txt
> @@ -0,0 +1,46 @@
> +* Hisilicon Hi3519 Clock and Reset Generator(CRG)
> +
> +The Hi3519 CRG module provides clock and reset signals to various
> +controllers within the SoC.
> +
> +This binding uses the following bindings:
> +    Documentation/devicetree/bindings/clock/clock-bindings.txt
> +    Documentation/devicetree/bindings/reset/reset.txt
> +
> +Required Properties:
> +
> +- compatible: should be one of the following.
> +  - "hisilicon,hi3519-crg" - controller compatible with Hi3519 SoC.
> +
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +
> +- #clock-cells: should be 1.
> +
> +Each clock is assigned an identifier and client nodes use this identifier
> +to specify the clock which they consume.
> +
> +All these identifier could be found in <dt-bindings/clock/hi3519-clock.h>.

This header should be part of this patch.

> +
> +- #reset-cells: should be 2.
> +
> +A reset signal can be controlled by writing a bit register in the CRG module.
> +The reset specifier consists of two cells. The first cell represents the
> +register offset relative to the base address. The second cell represents the
> +bit index in the register.
> +
> +Example: CRG nodes
> +CRG: clock-reset-controller {

clock-reset-controller at 12010000

> +	compatible = "hisilicon,hi3519-crg";
> +        reg = <0x12010000 0x10000>;
> +        #clock-cells = <1>;
> +        #reset-cells = <2>;
> +};
> +
> +Example: consumer nodes
> +i2c0: i2c at 0x12110000 {

Drop '0x'

> +	compatible = "hisilicon,hi3519-i2c";
> +        reg = <0x12110000 0x1000>;
> +        clocks = <&CRG HI3519_I2C0_RST>;*/
> +        resets = <&CRG 0xE4 0>;

lowercase hex please

> +};
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-12-11 15:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  7:45 [PATCH v3 0/7] ARM: hisi: Add initial support including clock driver for Hi3519 soc Jiancheng Xue
2015-12-11  7:45 ` [PATCH v3 1/7] clk: hisilicon: add CRG driver for hi3519 soc Jiancheng Xue
2015-12-11  7:45 ` [PATCH v3 2/7] clk: hisilicon: add dt-binding document for Hi3519 CRG Jiancheng Xue
2015-12-11 15:19   ` Rob Herring [this message]
2015-12-14  1:45     ` xuejiancheng
2015-12-11  7:45 ` [PATCH v3 3/7] ARM: hisi: add dt_machine definition for Hi3519 Jiancheng Xue
2015-12-11 15:21   ` Rob Herring
2015-12-14  2:07     ` xuejiancheng
2015-12-11  7:45 ` [PATCH v3 4/7] ARM: config: hisi: enable CONFIG_RESET_CONTROLLER Jiancheng Xue
2015-12-11  7:45 ` [PATCH v3 5/7] ARM: debug: add hi3519 debug uart Jiancheng Xue
2015-12-11  7:45 ` [PATCH v3 6/7] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Jiancheng Xue
2015-12-11 16:37   ` Rob Herring
2015-12-11  7:45 ` [PATCH v3 7/7] ARM: dts: add dts files for Hi3519 Jiancheng Xue
2015-12-11 16:28   ` Rob Herring
2015-12-14  6:34     ` xuejiancheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151211151909.GA21272@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox