linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 2/2] ARM: dts: imx6q: add Novena board
Date: Mon, 14 Dec 2015 04:56:07 +0100	[thread overview]
Message-ID: <201512140456.08114.marex@denx.de> (raw)
In-Reply-To: <20151214013845.GP11252@tiger>

On Monday, December 14, 2015 at 02:38:45 AM, Shawn Guo wrote:
> On Sat, Dec 12, 2015 at 04:27:13AM +0100, Marek Vasut wrote:
> > From: Sean Cross <xobs@kosagi.com>
> > 
> > Novena is an open-hardware laptop/desktop/bare board.
> > 
> > See http://www.kosagi.com/w/index.php?title=Novena_Main_Page
> > 
> > Signed-off-by: Sean Cross <xobs@kosagi.com>
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Sean Cross <xobs@kosagi.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> 
> It looks pretty good to me now, except a small question below.

Thanks

> > ---
> > 
> >  arch/arm/boot/dts/Makefile         |   1 +
> >  arch/arm/boot/dts/imx6q-novena.dts | 789
> >  +++++++++++++++++++++++++++++++++++++ 2 files changed, 790
> >  insertions(+)
> >  create mode 100644 arch/arm/boot/dts/imx6q-novena.dts
> 
> <snip>
> 
> > +/ {
> > +	model = "Kosagi Novena Dual/Quad";
> > +	compatible = "kosagi,imx6q-novena", "fsl,imx6q";
> > +
> > +	memory {
> > +		reg = <0x10000000 0xefffffff>;
> 
> What's the trick of having memory size being 0xefffffff?

That is a typo, should obviously be 0xffffffff , I just tested it on the board.
Thanks for spotting it, do you want me to repost a V5 or can you fix it ?

Best regards,
Marek Vasut

  reply	other threads:[~2015-12-14  3:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28 14:47 [PATCH V2 1/2] devicetree: bindings: Add vendor prefix for Kosagi Marek Vasut
2015-11-28 14:47 ` [PATCH V3 2/2] ARM: dts: imx6q: add Novena board Marek Vasut
2015-11-30 10:19   ` Lucas Stach
2015-11-30 12:21     ` Marek Vasut
2015-11-30 10:57   ` Fabio Estevam
2015-12-02  7:53   ` Shawn Guo
2015-12-02 15:41     ` Marek Vasut
2015-12-11 11:07       ` Shawn Guo
2015-12-12  3:25         ` Marek Vasut
2015-12-12  3:27         ` [PATCH V4 " Marek Vasut
2015-12-14  1:38           ` Shawn Guo
2015-12-14  3:56             ` Marek Vasut [this message]
2015-12-14 13:53               ` Sergei Shtylyov
2015-12-14 14:12                 ` Marek Vasut
2015-12-14 14:17                   ` Fabio Estevam
2015-12-14 14:41                     ` Marek Vasut
2015-12-14 14:45                       ` Fabio Estevam
2015-12-14 14:47                         ` Marek Vasut
2015-12-15  3:33                           ` Marek Vasut
2015-12-14  1:36 ` [PATCH V2 1/2] devicetree: bindings: Add vendor prefix for Kosagi Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201512140456.08114.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).