From mboxrd@z Thu Jan  1 00:00:00 1970
From: marex@denx.de (Marek Vasut)
Date: Mon, 14 Dec 2015 04:56:07 +0100
Subject: [PATCH V4 2/2] ARM: dts: imx6q: add Novena board
In-Reply-To: <20151214013845.GP11252@tiger>
References: <20151211110700.GD11252@tiger>
 <1449890833-7195-1-git-send-email-marex@denx.de>
 <20151214013845.GP11252@tiger>
Message-ID: <201512140456.08114.marex@denx.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Monday, December 14, 2015 at 02:38:45 AM, Shawn Guo wrote:
> On Sat, Dec 12, 2015 at 04:27:13AM +0100, Marek Vasut wrote:
> > From: Sean Cross <xobs@kosagi.com>
> > 
> > Novena is an open-hardware laptop/desktop/bare board.
> > 
> > See http://www.kosagi.com/w/index.php?title=Novena_Main_Page
> > 
> > Signed-off-by: Sean Cross <xobs@kosagi.com>
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Sean Cross <xobs@kosagi.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> 
> It looks pretty good to me now, except a small question below.

Thanks

> > ---
> > 
> >  arch/arm/boot/dts/Makefile         |   1 +
> >  arch/arm/boot/dts/imx6q-novena.dts | 789
> >  +++++++++++++++++++++++++++++++++++++ 2 files changed, 790
> >  insertions(+)
> >  create mode 100644 arch/arm/boot/dts/imx6q-novena.dts
> 
> <snip>
> 
> > +/ {
> > +	model = "Kosagi Novena Dual/Quad";
> > +	compatible = "kosagi,imx6q-novena", "fsl,imx6q";
> > +
> > +	memory {
> > +		reg = <0x10000000 0xefffffff>;
> 
> What's the trick of having memory size being 0xefffffff?

That is a typo, should obviously be 0xffffffff , I just tested it on the board.
Thanks for spotting it, do you want me to repost a V5 or can you fix it ?

Best regards,
Marek Vasut