From: treding@nvidia.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/5] soc: rockchip: add reboot notifier driver
Date: Tue, 15 Dec 2015 17:31:22 +0100 [thread overview]
Message-ID: <20151215163120.GA24031@ulmo.nvidia.com> (raw)
In-Reply-To: <10162108.nOThMrrbdf@wuerfel>
On Mon, Dec 14, 2015 at 12:39:44PM +0100, Arnd Bergmann wrote:
> On Wednesday 18 November 2015 17:56:22 Andy Yan wrote:
> > rockchip platform have a protocol to pass the kernel reboot
> > mode to bootloader by some special registers when system reboot.
> > By this way the bootloader can take different action according
> > to the different kernel reboot mode, for example, command
> > "reboot loader" will reboot the board to rockusb mode, this is
> > a very convenient way to get the board enter download mode.
> >
> > Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> Adding John Stultz to Cc
>
> I just saw this thread pop up again, and had to think of John's recent
> patch to unify this across platforms.
>
> John, can you have a look at this driver too, and see how it fits in?
> I think this is yet another variant, using an MMIO register rather than
> RAM (as HTC / NVIDIA does) or SRAM (as Qualcomm does), but otherwise
> it conceptually fits in with what you had.
FWIW, Tegra typically does use an MMIO register as well. See
drivers/soc/tegra/pmc.c:tegra_pmc_restart_notify(). I don't know what
HTC does, but if it's writing somewhere in RAM it isn't using the
standard way of resetting the SoC. There's early boot ROM code which I
think evaluates the PMC_SCRATCH0 register on Tegra to determine which
mode to boot into. That's before even any firmware gets the chance of
doing anything.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151215/f4a6bc92/attachment.sig>
next prev parent reply other threads:[~2015-12-15 16:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 9:47 [PATCH v3 0/5] Add reboot notifier driver for rockchip platform Andy Yan
2015-11-18 9:50 ` [PATCH v3 1/5] ARM: dts: rockchip: rk3288-veyron: rename pinctrl node reboot to reset Andy Yan
2015-11-18 14:18 ` Sergei Shtylyov
2015-11-18 9:53 ` [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver Andy Yan
2015-11-18 22:59 ` Rob Herring
2015-11-19 1:17 ` Andy Yan
2015-11-19 4:35 ` Heiko Stuebner
2015-11-20 1:16 ` Andy Yan
2015-11-20 1:58 ` Rob Herring
2015-11-19 12:56 ` Thierry Reding
[not found] ` <CANbgqASc1fyoV6FJ1g15P27_h0iA_F9h8aP304X8tRovrKrq5A@mail.gmail.com>
2015-11-19 15:30 ` Thierry Reding
2015-11-18 9:56 ` [PATCH v3 3/5] soc: rockchip: add " Andy Yan
2015-11-19 0:39 ` kbuild test robot
2015-12-14 11:39 ` Arnd Bergmann
2015-12-15 16:31 ` Thierry Reding [this message]
2015-12-15 16:34 ` Arnd Bergmann
2015-12-15 17:27 ` Heiko Stübner
2015-12-15 17:42 ` Thierry Reding
2015-12-15 20:38 ` Arnd Bergmann
2015-12-28 9:20 ` Thierry Reding
2015-12-28 15:35 ` Arnd Bergmann
2016-01-21 16:20 ` Thierry Reding
2015-11-18 10:00 ` [PATCH v3 4/5] ARM: dts: rockchip: add reboot node Andy Yan
2015-11-18 10:05 ` [PATCH v3 5/5] ARM64: " Andy Yan
[not found] ` <CANbgqARHxXorh8Svuw7tHMT60=j35BEqhMnuCOB6u6-d0NPxEQ@mail.gmail.com>
[not found] ` <CANbgqARCYP0rfTPSJLNEnCdrb1+mCYYznnRVH6o8Bj5sWt9fDw@mail.gmail.com>
2015-12-01 15:47 ` [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver Heiko Stübner
2015-12-11 21:29 ` [PATCH v3 0/5] Add reboot notifier driver for rockchip platform Heiko Stübner
2015-12-14 10:30 ` Andy Yan
2015-12-17 1:16 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215163120.GA24031@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).