From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v7 2/4] Documentation, dt, arm64/arm: dt bindings for numa.
Date: Fri, 18 Dec 2015 14:18:26 +0000 [thread overview]
Message-ID: <20151218141826.GB30229@leverpostej> (raw)
In-Reply-To: <1450413433-7467-1-git-send-email-gkulkarni@caviumnetworks.com>
Hi,
> +==============================================================================
> +2 - numa-node-id
> +==============================================================================
> +
> +For the purpose of identification, each NUMA node is associated with a unique
> +token known as a node id. For the purpose of this binding
> +a node id is a 32-bit integer.
> +
> +A device node is associated with a NUMA node by the presence of a
> +numa-node-id property which contains the node id of the device.
> +
> +Example:
> + /* numa node 0 */
> + numa-node-id = <0>;
> +
> + /* numa node 1 */
> + numa-node-id = <1>;
> +
> +==============================================================================
> +3 - distance-map
> +==============================================================================
> +
> +The device tree node distance-map describes the relative
> +distance(memory latency) between all numa nodes.
> +
> +- compatible : Should at least contain "numa-distance-map-v1".
Thank you for updating these per my request.
The fact that these have changed since the late posting [1] means that
this is a new version of the patch rather than a resend. Please update
the PATCHvX number when changes are made.
You also need to update the driver for the new compatible string, so a
new version of that is required.
> +- distance-matrix
> + This property defines a matrix to describe the relative distances
> + between all numa nodes.
> + It is represented as a list of node pairs and their relative distance.
> +
> + Note:
> + 1. Each entry represents distance from first node to second node.
> + The distance are equal in either direction.
> + 2. The distance from a node to self(local distance) is represented
> + with value 10 and all inter node distance should be represented with
> + value greater than 10.
> + 3. distance-matrix shold have entries in lexicographical ascending
> + order of nodes.
> + 4. There must be only one Device node distance-map and must reside in the root node.
I am still concerned that the local distance of 10 is completely
arbitrary.
Please:
* Add a new local-distance property to the distance-map node allowing a
uniform local distance to be described, and require this property to
be present.
* Update the driver to account for that and the compatible string
change.
* Send a complete PATCHv8 (or PATCHv$X where X > 7) series with a proper
changelog.
Thanks,
Mark.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/385826.html
next prev parent reply other threads:[~2015-12-18 14:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 4:37 [RESEND PATCH v7 2/4] Documentation, dt, arm64/arm: dt bindings for numa Ganapatrao Kulkarni
2015-12-18 14:18 ` Mark Rutland [this message]
2015-12-18 15:30 ` Ganapatrao Kulkarni
2015-12-18 18:03 ` Mark Rutland
2015-12-19 2:49 ` Ganapatrao Kulkarni
2015-12-21 14:27 ` Will Deacon
2015-12-22 12:54 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218141826.GB30229@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).