[PATCH v2 1/2] ARM: dts: imx7d: cl-som-imx7: add basic module support

Igor Grinberg
2015-12-22T14:07:51Z

Hi Shawn,

On 12/22/15 14:17, Shawn Guo wrote:
> On Tue, Dec 22, 2015 at 10:15:19AM +0200, Ilya Ledvich wrote:

[...]

>> +/ {
>> + model = "CompuLab CL-SOM-iMX7";
>> + compatible = "compulab,cl-som-imx7", "fsl,imx7d";
>> +
>> + memory {
>> + reg = <0x80000000 0x10000000>; /* 256 MB - minimal configuration */
>> + };
>> +
>> + regulators {
>> + compatible = "simple-bus";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>
> DT maintainers dislike this fake "simple-bus" container, and we were
> asked to put fixed regulator directly under root. I fixed it up like
> below:
>
> reg_usb_otg1_vbus: regulator-vbus {
> compatible = "regulator-fixed";
> regulator-name = "usb_otg1_vbus";
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> };
>

Looks good! Thanks for adjusting this.

[...]

--
Regards,
Igor.