From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@linaro.org (Viresh Kumar) Date: Wed, 23 Dec 2015 16:11:06 +0530 Subject: [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id In-Reply-To: <1450867041-729-1-git-send-email-a.hajda@samsung.com> References: <1450867041-729-1-git-send-email-a.hajda@samsung.com> Message-ID: <20151223104105.GB3455@ubuntu> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 23-12-15, 11:37, Andrzej Hajda wrote: > The function can return negative values, so its result should > be assigned to signed variable. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda > --- > drivers/cpufreq/scpi-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c > index 2c3b16f..de5e89b 100644 > --- a/drivers/cpufreq/scpi-cpufreq.c > +++ b/drivers/cpufreq/scpi-cpufreq.c > @@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops; > > static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev) > { > - u8 domain = topology_physical_package_id(cpu_dev->id); > + int domain = topology_physical_package_id(cpu_dev->id); > > if (domain < 0) > return ERR_PTR(-EINVAL); Acked-by: Viresh Kumar -- viresh