From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional
Date: Sun, 3 Jan 2016 19:30:12 +0100 [thread overview]
Message-ID: <20160103183012.GE1522@katana> (raw)
In-Reply-To: <CACRpkdbb-GFJSVvxOLda6CVG_fB2zAPPC2MMzQ6P1mAfvsrkPw@mail.gmail.com>
On Mon, Nov 30, 2015 at 01:55:19PM +0100, Linus Walleij wrote:
> On Fri, Nov 20, 2015 at 10:45 PM, Li Yang <leoli@freescale.com> wrote:
>
> > - if (IS_ERR(i2c_imx->pinctrl)) {
> > + /* bailout on -ENOMEM or -EPROBE_DEFER, continue for other errors */
> > + if (PTR_ERR(i2c_imx->pinctrl) == -ENOMEM ||
> > + PTR_ERR(i2c_imx->pinctrl) == -EPROBE_DEFER) {
>
> This is one of the evils of deferred probe: you never know if
> something will eventually turn up. It feels wrong to bail out
> on deferred probe...
>
> I have no better idea though.
> Acked-by
Linus, proper ack next time please, so patchwork will pick it up
automatically.
Li Yang: There have been some other changes to the imx driver. Could you
rebase against my for-next or for-4.5 and add Linus' ack? Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160103/53375360/attachment.sig>
prev parent reply other threads:[~2016-01-03 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 21:45 [PATCH v2] i2c: imx: make bus recovery through pinctrl optional Li Yang
2015-11-30 12:55 ` Linus Walleij
2016-01-03 18:30 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160103183012.GE1522@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).